Cleanup macro invoc #2981
Open
Cleanup macro invoc #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok i appear to have developed this from another branch other than master, fixing it rn |
Remove get_macro_node_id in favor of get_node_id in MacroInvocation Add ExteralItem node_id constructor to avoid extra get_node_id() gcc/rust/ChangeLog: * ast/rust-macro.h: Likewise. * resolve/rust-early-name-resolver.cc (EarlyNameResolver::visit): Likewise. * util/rust-hir-map.cc (Mappings::insert_macro_invocation): Likewise. (Mappings::lookup_macro_invocation): Likewise. (Mappings::insert_bang_proc_macro_invocation): Likewise. (Mappings::lookup_bang_proc_macro_invocation): Likewise.
badumbatish
force-pushed
the
cleanup_macro_invoc
branch
from
9a64b91
to
8cf484d
Compare
|
@CohenArthur hi Arthur i'm not sure for things like node_id and locus, if you want to not explicitly declare them in MacroInvocation and just get_node_id and get_locus from the parent's class or if you just want to do them explicitly like what I've kept in the modification? Also not sure what else needs to be clean up for this class.. |
CohenArthur
reviewed
May 24, 2024
Comment on lines
468
to
471
| if (has_semicolon) | ||
| source_node = invoc.get_macro_node_id (); | ||
| source_node = invoc.get_node_id (); | ||
| else | ||
| source_node = invoc.get_node_id (); |
There was a problem hiding this comment.
see for example here we're no longer doing anything different if the macro has a semicolon or not, so we can remove the if block
There was a problem hiding this comment.
wow no idea how i missed this, thanks for the review, i'll resolve it along with new thoughts on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacroInvoc Refactor for #2919