Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add RAW_STRING_LITERAL #2902

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Add RAW_STRING_LITERAL #2902

wants to merge 1 commit into from

Conversation

AnshVM
Copy link

@AnshVM AnshVM commented Mar 4, 2024 •
edited

Fixes #2858

This PR adds the RAW_STRING_LITERAL token variant and the Literal::RAW_STIRNG variant.

CohenArthur
CohenArthur approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks great! as you mentioned on Zulip, it'd be nice to have a simple testcase but it doesn't need to be too complicated.

@CohenArthur
Copy link
Member

@AnshVM do you need any help with this?

@AnshVM
Copy link
Author

AnshVM commented Mar 23, 2024

@CohenArthur Yes, I had added a comment on zulip about this.
I wanted to ask if you have any suggestions of what kind of testcase I can add, since there are already testcases for raw strings in testsuite/rust/rawbytestring.rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenArthur CohenArthur CohenArthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AST::LiteralExpr should differentiate between strings and raw strings
2 participants
@AnshVM @CohenArthur