Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to check ActiveRecord prefix / suffix #432

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix to check ActiveRecord prefix / suffix #432

wants to merge 2 commits into from

Conversation

zaru
Copy link

@zaru zaru commented Jan 18, 2017

Fixes #296

When using config.active_record.table_name_prefix in ActiveRecord, the name of join table is not changed. This PR works well in my environment, but please advise if there is any problem.

@coveralls
Copy link

coveralls commented Nov 20, 2017 •
edited

Coverage Status

Coverage increased (+0.007%) to 93.096% when pulling 685246b on zaru:master into dffb0f6 on RolifyCommunity:master.

EppO
EppO requested changes Nov 20, 2017
View reviewed changes
Copy link
Member

@EppO EppO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution,
A test with ActiveRecord::Base.table_name_prefix set would be needed to check what is the impact when prefix is non-empty

@EppO EppO added the tests label Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO EppO requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table name prefix for join table
3 participants
@zaru @coveralls @EppO