Improve UI styling possibilities #685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The theme resource was done from scratch to avoid the use of unnecessary/outdated theme properties (a clean theme resource should make it easier to adjust and vary in the future). Things don't really look perfectly like I envision them, because there are some panels and other customization options missing. But I think this is a good start for a new theme. I've not made it the new default, just added it to the theme list. The theme uses the Rubik font, as suggested by Tarox.
This required some rework of the library scene (to have the container as the root). Not a lot though.
- this commit also adds a background style to the Tree again on the Modern Theme
- Makes the panel style customizable from the theme
- Reworks the list as an actual ItemList to be more performant
- Stores the entries "Name" when loading the library, to avoid doing lot's of string.split("/") when filtering.
- Implement selecting items in the list with Down arrow (when filter is focused)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to give more power to the theme, by adding some custom style variations and panels, use of PanelContainers (to control content margins), etc.
This PR uses the "Modern" theme from #683 to use these, to showcase how this can help with styling.
These are the individual changes:
Make the main background a PanelContainer with a custom style
Add PanelContainers to Library, Layers, Hierarchy
Use PanelContainer as Flexible Tab + Scroll Container as Tabs parent
Add custom style to filter LineEdit in library
Make sure theme is propagated to flexible layout windows
Add background panel to projects (behind previews)
Improve AddNode panel
This is the "Modern" theme afterwards:
