Allow drag-and-drop rearranging tabs and always display the Close button #325
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always displaying the Close button avoids layout shifts while changing tabs, which can have unexpected results when clicking around (such as accidentally closing tabs).
|
Hmm rearranging tabs does not seem to work well. I don't manage to drag a tab from all the way left to all the way right with only 3 tabs... |
I think I tested this on 3.2.3, but I don't remember it. Drag-and-drop to the extreme ends can be a bit finnicky at times. It should work better when dragging a tab between two other tabs. |
|
Could this be merged to resolve #359? Thanks in advance 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #324.
Always displaying the Close button avoids layout shifts while changing tabs, which can have unexpected results when clicking around (such as accidentally closing tabs).