Skip to content

Commit

Permalink
MNT: removing type hints for consistency with codebase (#444)
Browse files Browse the repository at this point in the history
  • Loading branch information
Lucas-Prates committed May 16, 2024
1 parent ef0ae7e commit b09d891
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
24 changes: 12 additions & 12 deletions rocketpy/sensitivity/sensivity_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ class SensitivityModel:

def __init__(
self,
parameters_names: list[str],
target_variables_names: list[str],
parameters_names,
target_variables_names,
):
self.__check_requirements()
self.n_parameters = len(parameters_names)
Expand Down Expand Up @@ -64,8 +64,8 @@ def __init__(

def set_parameters_nominal(
self,
parameters_nominal_mean: np.array,
parameters_nominal_sd: np.array,
parameters_nominal_mean,
parameters_nominal_sd,
):
"""Set parameters nominal mean and standard deviation
Expand Down Expand Up @@ -99,7 +99,7 @@ def set_parameters_nominal(

def set_target_variables_nominal(
self,
target_variables_nominal_value: np.array,
target_variables_nominal_value,
):
"""Set target variables nominal value (mean)
Expand All @@ -126,7 +126,7 @@ def set_target_variables_nominal(

def _estimate_parameter_nominal(
self,
parameters_matrix: np.matrix,
parameters_matrix,
):
"""Estimates parameters nominal values
Expand Down Expand Up @@ -154,7 +154,7 @@ def _estimate_parameter_nominal(

def _estimate_target_nominal(
self,
target_data: np.matrix,
target_data,
):
"""Estimates target variables nominal values
Expand Down Expand Up @@ -191,8 +191,8 @@ def _estimate_target_nominal(

def fit(
self,
parameters_matrix: np.matrix,
target_data: np.matrix,
parameters_matrix,
target_data,
):
"""Fits sensitivity model
Expand Down Expand Up @@ -337,7 +337,7 @@ def plot(self, target_variable="all"):

return

Check warning on line 338 in rocketpy/sensitivity/sensivity_model.py

View check run for this annotation

Codecov / codecov/patch

rocketpy/sensitivity/sensivity_model.py#L338

Added line #L338 was not covered by tests

def summary(self, digits=4, alpha=0.95) -> None:
def summary(self, digits=4, alpha=0.95):
"""Formats parameter sensitivity information in a prettytable
and prints it
Expand Down Expand Up @@ -439,8 +439,8 @@ def summary(self, digits=4, alpha=0.95) -> None:

def __check_conformity(
self,
parameters_matrix: np.matrix,
target_data: np.matrix,
parameters_matrix,
target_data,
):
"""Checks if matrices used for fitting conform with the
information passed at initialization
Expand Down
8 changes: 4 additions & 4 deletions rocketpy/tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -551,10 +551,10 @@ def generate_monte_carlo_ellipses_coordinates(


def load_monte_carlo_data(
input_filename: str,
output_filename: str,
parameters_list: list[str],
target_variables_list: list[str],
input_filename,
output_filename,
parameters_list,
target_variables_list,
):
"""Reads MonteCarlo simulation data file and builds parameters and flight
variables matrices from specified
Expand Down

0 comments on commit b09d891

Please sign in to comment.