Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unimplemented components from index #859

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tapiarafael
Copy link
Contributor

@tapiarafael tapiarafael commented Sep 30, 2022

Proposed changes (including videos or screenshots)

Remove unimplemented components from the index file, so they don't appear on the intellisense.

Issue(s)

Further comments

This change is made to avoid confusion during the development using ui-kit, since the components would not work as they aren't implemented yet.

Task AE-56

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ggazzo
Copy link
Member

ggazzo commented Oct 6, 2022

why not implement the components? since now we moved the fuselage-ui-kit to the main repo, thing are much easier to be done..

@ggazzo ggazzo added the wontfix This will not be worked on label Oct 6, 2022
@tassoevan
Copy link
Collaborator

I believe it's fine. The exposed API should really reflect what we have at the moment. Future components are better described in spec files.

@tapiarafael
Copy link
Contributor Author

why not implement the components? since now we moved the fuselage-ui-kit to the main repo, thing are much easier to be done..

I agree with you, but it's not the focus of the task at the moment. We are trying just to improve the experience of people that will use the fuselage, to not misunderstand what the available components are.

@dougfabris dougfabris changed the base branch from develop to main September 13, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants