Login errors in 3.1.0

[dusatvoj]

Description:

After upgrade to v3.1.0:

• I can't login to RC from Android App (v4.5.2)
• I lose login every time I close desktop app / firefox tab

Steps to reproduce:

1. Open desktop app / web browser
2. Login to server
3. Close web browser RC tab / dekstop app
4. Reopen app / browser tab

Expected behavior:

Login remains

Actual behavior:

After loading page is shown login page and error Invalid User

Server Setup Information:

• Version of Rocket.Chat Server: 3.1.0
• Operating System: Debian 9
• Deployment Method: tar
• Number of Running Instances: 1
• DB Replicaset Oplog: yes
• NodeJS Version: 12.14.0
• MongoDB Version: 3.6.17

Client Setup Information

• Desktop App or Browser Version: App 2.17.9-1, Browser firefox 75.0-1
• Operating System: Arch linux

Relevant logs:

Server

Nothing 😕

Browser

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFaviconService.replaceFaviconDataFromDataURL]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource:///modules/PlacesUIUtils.jsm :: loadFavicon :: line 209"  data: no] PlacesUIUtils.jsm:209:28
    loadFavicon resource:///modules/PlacesUIUtils.jsm:209
    loadFavicon resource:///modules/PlacesUIUtils.jsm:362
    setIconFromLink resource:///actors/LinkHandlerParent.jsm:154
    receiveMessage resource:///actors/LinkHandlerParent.jsm:71
TypeError: window is null 2 WebRequestContent.js:143:7
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIInterfaceRequestor.getInterface] network-response-listener.js:84
Sync encountered an error - see about:sync-log for the log file. policies.js:1008
    resetFileLog resource://services-sync/policies.js:1008
    InterpretGeneratorResume self-hosted:1156
    AsyncFunctionNext self-hosted:695

[DJeremyy]

Since the update to 3.1.0 made yesterday, I have the same errors when connecting to the web application. It disconnects after closing the tab with Invalid user.

iOS (4.6.3) and Android (4.5.2) application no longer works. Unable to connect when I reset the app.

[danielnachtrub]

We've got the same issue here. Started with an image upgrade.

Rocketchat is running in a docker-environment with nginx as reverse-proxy and LDAP backend. Docker is using the official image from hub.

• Client application running on Windows can login but loses session upon restart or server reload. Same on macOS.
• Running in browser rocketchat is working but after reloading the page the same error occurs.
• iOS app cannot login at all.

[Shaverdoff]

guys - option on Accoutn settigns - Forget User Session on Window Close is enabled?

[danielnachtrub]

guys - option on Accoutn settigns - Forget User Session on Window Close is enabled?

Not enabled here.

[dusatvoj]

guys - option on Accoutn settigns - Forget User Session on Window Close is enabled?

Disabled

[Shaverdoff]

Rc confgired with ldap? Отправлено с iPhone

…

11 апр. 2020 г., в 16:59, Daniel Nachtrub ***@***.***> написал(а):  guys - option on Accoutn settigns - Forget User Session on Window Close is enabled? Not enabled here. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[DJeremyy]

guys - option on Accoutn settigns - Forget User Session on Window Close is enabled?

Disabled for me

[danielnachtrub]

Rc confgired with ldap? Отправлено с iPhone
…
11 апр. 2020 г., в 16:59, Daniel Nachtrub @.***> написал(а):  guys - option on Accoutn settigns - Forget User Session on Window Close is enabled? Not enabled here. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

We're using LDAP authentication.

[DJeremyy]

Rc confgired with ldap? Отправлено с iPhone
…
11 апр. 2020 г., в 16:59, Daniel Nachtrub @.***> написал(а):  guys - option on Accoutn settigns - Forget User Session on Window Close is enabled? Not enabled here. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Yes, I'm use LDAP sync for accounts and authentication.

[Shaverdoff]

Its strange. I use the same conf and set. No login errors Отправлено с iPhone

…

11 апр. 2020 г., в 17:20, DJeremyy ***@***.***> написал(а):  Rc confgired with ldap? Отправлено с iPhone … 11 апр. 2020 г., в 16:59, Daniel Nachtrub @.***> написал(а):  guys - option on Accoutn settigns - Forget User Session on Window Close is enabled? Not enabled here. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Yes, I'm use LDAP sync for accounts and authentication. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[dusatvoj]

I have LDAP enabled

[danielnachtrub]

Checking the console output from devtools on client it states:

Error logging in with token: Error: Login forbidden [403]
E2E -> Stop Client

[danielnachtrub]

I found a workaround in our environment:
By enabling Login Fallback the issues do not arise anymore.

Seems that there's an issue to recognize existing sessions here. Perhaps request is cancelled when login fallback is disabled and therefore even existing sessions using tokens can't be validated.

[DJeremyy]

I found a workaround in our environment:
By enabling Login Fallback the issues do not arise anymore.

This is also the case for me @danielnachtrub, activating 'Login Fallback' in the LDAP section no longer causes connection problems on Android and iOS. I no longer have 'Invalid user' when I close the tab and open it again.

[Shaverdoff]

On 3.1.0 developers attache able to login without ldap if ldap is enabled and configured. So localy account

…

-- Gerasim Shaverdov | Deputy CTO | Altarix Mobile: <tel:+7%20937%20070%2066%2084> +7 937 070 66 84 | Skype/email: <mailto:gerasim@altarix.ru> gerasim@altarix.ru Lenina av.25, Samara, Russia, 443068 From: DJeremyy <notifications@github.com> Sent: Sunday, April 12, 2020 2:45 PM To: RocketChat/Rocket.Chat <Rocket.Chat@noreply.github.com> Cc: Шавердов Герасим Сергеевич <gerasim@altarix.ru>; Comment <comment@noreply.github.com> Subject: Re: [RocketChat/Rocket.Chat] Login errors in 3.1.0 (#17259) I found a workaround in our environment: By enabling Login Fallback the issues do not arise anymore. This is also the case for me @danielnachtrub <https://github.com/danielnachtrub> , activating 'Login Fallback' in the LDAP section no longer causes connection problems on Android and iOS. I no longer have 'Invalid user' when I close the tab and open it again. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#17259 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKOGQJUSW3KVH6MHOFQPMKDRMGLRHANCNFSM4MF6HPUQ> .