[NEW] Project 09 - Recording and sending audio VoiceOver accessible #2748
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2748 +/- ##
===========================================
- Coverage 46.1% 45.04% -1.07%
===========================================
Files 626 626
Lines 28938 28953 +15
===========================================
- Hits 13343 13042 -301
- Misses 15595 15911 +316
Continue to review full report at Codecov.
|
rudrankriyam
changed the title
There was a problem hiding this comment.
@rudrankriyam You did a really great work on this PR! 🎉
The only thing that wasn't working was the duration slider. It still says "0% adjustable". And maybe you wanna bring those changes over to the audio player in chat as well.
|
Awesome work. Thank you! |
rudrankriyam
changed the title
| progressSlider.setValue(progressSlider.value - 10, animated: true) | ||
| valueUpdated() | ||
| } | ||
| } |
There was a problem hiding this comment.
File Line Length Violation: File should contain 400 lines or less: currently contains 449 (file_length)
| @@ -397,3 +420,30 @@ extension AudioView { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| // MARK: Accessibility | |||
There was a problem hiding this comment.
Mark Violation: MARK comment should be in valid format. e.g. '// MARK: ...' or '// MARK: - ...' (mark)
| self.timeLabel.text = displayFormat | ||
| self.timeLabel.accessibilityLabel = ComposerView.localized(.durationLabel) + self.timeDuration(displayTime) | ||
|
|
||
| self.progressSlider.accessibilityValue = ComposerView.localized(.sliderLabelPosition) + self.timeDuration(Int(player.currentTime)) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 142 characters (line_length)
@RocketChat/ios
The following buttons are described in VoiceOver with a redundant “Button”
I hid the accessibilityElements wherever applicable so it provides a smooth VoiceOver experience.