Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FIX] Updated development environment setup instructions #2575

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

prateekguptaiiitk
Copy link

@RocketChat/ios

Closes #2553

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #2575 into develop will decrease coverage by 19.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2575       +/-   ##
============================================
- Coverage    46.21%   26.49%   -19.72%     
============================================
  Files          625      456      -169     
  Lines        28917    16903    -12014     
============================================
- Hits         13364     4479     -8885     
+ Misses       15553    12424     -3129
Impacted Files Coverage Δ
...at/Models/Subscription/UnmanagedSubscription.swift 0% <0%> (-94.24%) ⬇️
Rocket.Chat/Models/User/UnmanagedUser.swift 0% <0%> (-70.59%) ⬇️
...Chat/Models/Mapping/LoginServiceModelMapping.swift 0% <0%> (-66.3%) ⬇️
...anagers/Model/AuthManager/AuthManagerRecover.swift 36.36% <0%> (-60.61%) ⬇️
....Chat/Controllers/Auth/WelcomeViewController.swift 30% <0%> (-36.67%) ⬇️
Rocket.Chat/Extensions/Models/AuthExtensions.swift 66.66% <0%> (-33.34%) ⬇️
...t/Views/Subscriptions/SubscriptionsTitleView.swift 12.5% <0%> (-32.24%) ⬇️
Rocket.Chat/Helpers/VoiceOver/VOLocalized.swift 0% <0%> (-25%) ⬇️
Rocket.Chat/Managers/AnalyticsManager.swift 36.17% <0%> (-19.72%) ⬇️
Rocket.Chat/Managers/PushManager.swift 24.13% <0%> (-19.46%) ⬇️
... and 334 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5480a6...c0994bf. Read the comment docs.

3. Build the project by ⌘ + R

2. Navigate to the unzipped folder and run the following commands-</br>
`pod deintegrate`</br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prateekguptaiiitk Why deintegrate is necessary here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pod deintegrate helps to remove all traces of Cocoapods from the project. So after that if we do pod install we can start to install them afresh. pod update will solve any version inconsistencies. Without pod deintegrate project was throwing random build errors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prateekguptaiiitk pod update will cause the CocoaPods to update libraries even if they're not in the same version as in Podfile.lock, right? It could cause some inconsistencies between projects in this case I think. Just pod install should be enough for anyone cloning the project, but most of the time that's not even necessary because the Pods folder is already being cloned.

Have you experienced any problems cloning the app for the first time and running it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @rafaelks I along with some others experienced problems while setting up the project for the first time and running it. Even running pod install didn't help. When I ran pod deintegrate and then pod install my problem was resolved and project was built successfully.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I didn't experience any problem setting up the project for the first time, as the Pods were already there, I think the problem is usually with updating swiftlint and fastlane.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTION] Pod install make build not working
4 participants