Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fest: close button added in setting #2890

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yash-kh
Copy link

@yash-kh yash-kh commented May 13, 2024

Close button added in setting

Used the reducer action from side nav to fix the issue.
This is my first PR in this repo, I would love to hear your feedback and suggestion, thanks.

Closes #2876

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


yash-kh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@yash-kh yash-kh changed the title fest: close button added in setting #2876 fest: close button added in setting May 13, 2024
@yash-kh
Copy link
Author

yash-kh commented May 13, 2024

Screen.Recording.2024-05-13.at.3.28.08.PM.mov

@yash-kh
Copy link
Author

yash-kh commented May 14, 2024

@jeanfbrito Please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to exit settings when Sidebar is hidden
2 participants