Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Rewrite gulpfile in typescript #395

Open
wants to merge 3 commits into
base: alpha
Choose a base branch
from

Conversation

aditya-mitra
Copy link
Contributor

What? ⛵

Closes #393

  1. Added:
    -gulpfile.ts,
  • npm type definitions for gulp, gulp-bump and gulp-sourcemaps
  • gupfile.d.ts for those modules which did not have type definitions found in npm
  1. Updated:
  1. Removed:
  • gulpfile.js

Why? 🤔

Since most of the codebase of Rocket.Chat.Apps-engine is written in typescript, it would be nicer if we could write gulpfile also in typescript. smiley

Links 🌎

Issue #393

PS 👀

added types from the same in package.json (which could be found)
added .d.ts file in tsconfig
@CLAassistant
Copy link

CLAassistant commented Mar 11, 2021

CLA assistant check
All committers have signed the CLA.

@aditya-mitra
Copy link
Contributor Author

aditya-mitra commented Mar 11, 2021

Hi,
The compilation is passing locally but failing on CircleCI. (I even tried this on a fresh GitPod instance and it was working)

image

What is the reason for this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW FEATURE] Convert gulpfile to typescript
2 participants