Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhc: Code Refactoring, Project Restructuring, and Unified Stylings #576

Merged
merged 88 commits into from May 14, 2024

Conversation

Spiral-Memory
Copy link
Contributor

@Spiral-Memory Spiral-Memory commented May 8, 2024

Brief Title

Acceptance Criteria Fulfillment

  • Removed Module.css files.
  • Added inline stylings with Emotion CSS.
  • Removed hotfix and added actual fix for emoji alignment.
  • Removed older grid component (non-functional).
  • Added a new grid component without any Module.css files.
  • Fixed modal stylings.
  • Refactored search component into sidebar.
  • Refactored Attachment Component (It was using unnecessary code instead of using the component modal).
  • Added styles.js files for components exceeding 2 lines of CSS.
  • Changed <div> and <span> to <Box>.
  • Basic project restructuring: separated core components from views.

Fixes #575

Video/Screenshots

A video demonstrating that all major features are working properly after these changes.

2024-05-12.22-32-00.mp4

@Spiral-Memory Spiral-Memory marked this pull request as draft May 8, 2024 07:29
@Spiral-Memory Spiral-Memory force-pushed the enhc/stylings-refactor branch 2 times, most recently from cddee04 to ab813e8 Compare May 8, 2024 09:53
made actual fix

removed module.css and unnecessary styles.js files
added a new grid system without module css
@Spiral-Memory Spiral-Memory changed the title enhc: stylings refactor Enhancement: Code Refactoring, Project Restructuring, and Unified Stylings May 12, 2024
@Spiral-Memory Spiral-Memory marked this pull request as ready for review May 12, 2024 16:54
@Spiral-Memory
Copy link
Contributor Author

Spiral-Memory commented May 12, 2024

Hey @sidmohanty11 , I've made some changes related to refactoring many components' code and unifying the stylings, and I've done a simple restructuring of the project, separating components and views.

As far as I have tested, I'm seeing things working fine. However, since this PR has a lot of changes, there is a high chance of introducing bugs into the project, which I'll correct as soon as I notice them. Hence, I suggest creating a new branch 'v0.2' for the changes up to this point to preserve the project. Without that, it's unsafe to merge. Once you create a new branch, please review and merge it to 'develop' branch, and I'll fix any arising issues. Also, please don't squash and commit for this PR; otherwise, it will become difficult to go back to certain changes and drop or revert them.

@Spiral-Memory Spiral-Memory changed the title Enhancement: Code Refactoring, Project Restructuring, and Unified Stylings enhancement: Code Refactoring, Project Restructuring, and Unified Stylings May 13, 2024
@Spiral-Memory Spiral-Memory changed the title enhancement: Code Refactoring, Project Restructuring, and Unified Stylings enhc: Code Refactoring, Project Restructuring, and Unified Stylings May 13, 2024
@sidmohanty11 sidmohanty11 changed the base branch from develop to v0.2.0 May 14, 2024 14:20
@sidmohanty11 sidmohanty11 changed the base branch from v0.2.0 to develop May 14, 2024 14:25

// Example Usage

/* <Grid
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@sidmohanty11 sidmohanty11 merged commit 5ef0947 into RocketChat:develop May 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhc]: Standardize design across project with style refactor and folder reorg.
2 participants