Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add confirm modal before pinning messages #479

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Akshun-01
Copy link
Contributor

Implement Confirmation before Pinning Message feature

Acceptance Criteria fulfillment

  • Check for the state to trigger the modal
  • Make the confirmation Modal
  • Handle confirmation or canceling of the modal

Fixes #450

Video/Screenshots

pinMsgConfirm.mp4

Copy link
Collaborator

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Akshun-01 but I'm not sure if this addition is necessary

@Akshun-01
Copy link
Contributor Author

Yeah, Zishan and I also discussed the same.
I could only think of one use case where this might be important or necessary.
Integration in a professional platform where you can't go on pinning stuff by mistake as it is public and can't be deleted.
But yeah, a very niche use case and can be ignored in most cases.
So, we can leave the feature out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirmation Before Pinning message
2 participants