Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue: #369 #380

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

devanshkansagra
Copy link

@devanshkansagra devanshkansagra commented Jan 2, 2024

Implementation of toggling the visiblity of password

Acceptance Criteria fulfillment

  • Add the eye icon (make sure its responsive)
  • Add the toggling logic to it

Fixes #369

Output

Screencast.from.01-01-24.09.59.37.PM.IST.webm

@devanshkansagra
Copy link
Author

Please review my this pull request because I was forced to close the previous pull requests of this issue due to conflicts. This is the final Pull request. Let me know if there are any changes or any tasks regarding this issue. If there are then I would be happy to contribute to this project.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility] : Ability to toggle Password Visibility
1 participant