Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue: #350 #377

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

devanshkansagra
Copy link

Fixes #350

Implementation:

Imported the Tooltip component (Tooltip.js) in MessageToolbox.js.

A part of code

<Tooltip text="Edit" position="top">
  <ActionButton
    ghost={!isEditing}
    color={isEditing ? 'secondary' : 'default'}
    size="small"
    icon="edit"
    onClick={() => handleEditMessage(message)}
  />
</Tooltip>

Output

Screencast.from.25-12-23.01.22.29.AM.IST.webm

@devanshkansagra
Copy link
Author

This is the same new PR which was closed before. All the changes are same nothing is changed. If there are any changes to be made the tell me I would happy to contribute to this project

Copy link
Collaborator

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @devanshkansagra thanks for the PR, seems like you've added an extra package-lock file and yarn-lock changes but I don't see any dependency changes so this should not be the case

@devanshkansagra
Copy link
Author

devanshkansagra commented Jan 3, 2024

@sidmohanty11, Actually I setup the server on gitpod so due to that those files were added

@abhinavkrin
Copy link
Member

@sidmohanty11, Actually I setup the server on gitpod so due to that those files were added

Hey @devanshkansagra , you should remove package-lock.json. Run yarn. Commit and push if any changes occur in the yarn.lock file

@devanshkansagra
Copy link
Author

Ok, Noted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Menu-Item name when hovered over message menu-item
3 participants