Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation Before Pinning message #450

Open
2 tasks
Akshun-01 opened this issue Feb 7, 2024 · 2 comments · May be fixed by #479
Open
2 tasks

Confirmation Before Pinning message #450

Akshun-01 opened this issue Feb 7, 2024 · 2 comments · May be fixed by #479
Labels
enhancement New feature or request

Comments

@Akshun-01
Copy link
Contributor

Akshun-01 commented Feb 7, 2024

As an EmbeddedChat developer

I need to:
Add a confirmation popup before pinning a message.
image

So That:
The user knows pinned messages are visible for everyone to see. It increases the user experience.
And as it is an extension of RocketChat, it would make it more similar and consistent.

Acceptance Criteria

  • Check pin status for message and give popup accordingly
  • on confirmation pin the message otherwise return
@Akshun-01 Akshun-01 added the enhancement New feature or request label Feb 7, 2024
@Spiral-Memory
Copy link
Contributor

Spiral-Memory commented Feb 7, 2024

Hey @Akshun-01 , would it be a good feature to have in embedded chat? I mean, I feel this app is mainly for integration into different platforms to streamline workflows. Adding an extra modal to confirm whether we want to pin may not be a very suitable idea in my opinion. The maintainers however will know better. You can ask them if you want.

@Akshun-01
Copy link
Contributor Author

Hey Zishan, I was also ambiguous about this issue and have been keeping it at hold for quite some time now. But I think it is a good addition, I get your point about its importance but I think if you consider a scenario where it is integrated someplace where professional discussions are taking place, there u dont want that ur messages get pinned by mistake. That would not be a good impression, although its something many would just ignore but still the fact we can't delete the pinned message so it would be a little better if we know we are pinning something.
Also if something is implemented in rocketchat, they must have thought it through.
But, yes at the end it's upto the maintainers, how they want their app to function.
Thanks for this thought! 🙌

@Akshun-01 Akshun-01 linked a pull request Feb 22, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants