Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(noti): use simple implementation instead #46

Merged
merged 2 commits into from May 11, 2024

Conversation

Mini-ghost
Copy link
Contributor

@Mini-ghost Mini-ghost commented Mar 4, 2024

πŸ”— Linked issue

N/A

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We replaced @vueuse/core with a simpler implementation. This not only reduces the performance cost during plugin installation but also decreases the bundle size a bit (if the project doesn't use useCounter).

Bundle Size

Before:

index.es.js    6.77kb | gzip: 2.27kb
index.umd.js   5.07kb | gzip: 1.98kb

After:

index.es.js    6.75kb | gzip: 2.26kb
index.umd.js   5.05kb | gzip: 1.97kb

For projects not using useCounter (example: playground):

Before:

index.js       70.39kb | gzip: 27.11kb

After:

index.js       70.07kb | gzip: 26.94kb

This is a minor improvement, but it can slightly reduce the bundle size without forcing users to install @vueuse/core.

πŸ“ Checklist

  • I have read the Contributing Guidelines.
  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
vue3-noti βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 11, 2024 6:26am
vue3-noti-i2l4 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 11, 2024 6:26am

@Rock070
Copy link
Owner

Rock070 commented May 11, 2024

appreciated !

@Rock070 Rock070 merged commit 5b0d8f6 into Rock070:main May 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants