Suspend event listeners during reconciliation?

[LPGhatguy]

A common source of bugs in Roact code that I've seen involves hooking into Changed or using GetPropertyChangedSignal, and calling setState in response.

This pattern is perfectly fine as long as the reconciler doesn't affect the properties you're listening to synchronously. I use this technique in my Roact Windowing example to make the windowing responsive to your current scroll position.

One idea that @AmaranthineCodices had would be to suspend those events while the reconciler is running, eliminating that entire class of bugs.

Are there any cases where you'd want these events? It's only problematic when you end up calling setState directly or indirectly.

[LPGhatguy]

There is a bit of precedence for this in certain contexts -- React defers re-rendering when setState is called inside one of the brower's (synchronous) event handlers.

It's possible that we should do the same thing for events! I imagine this would prevent a lot of bugs, too!

[ZoteTheMighty]

This was implemented in #48!!