Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

New reconciler #48

Closed
LPGhatguy opened this issue Mar 13, 2018 · 2 comments · Fixed by #104
Closed

New reconciler #48

LPGhatguy opened this issue Mar 13, 2018 · 2 comments · Fixed by #104
Assignees

Comments

@LPGhatguy
Copy link
Contributor

LPGhatguy commented Mar 13, 2018

The reconciler is starting to get pretty darn big, complicated, and a bit convoluted.

I'd like to take another stab at rewriting it from the ground up with better-defined types, and to be a little bit more robust.

My wishlist for the new reconciler:

@AmaranthineCodices
Copy link
Contributor

One idea I keep coming back to related to this: what if we had multiple reconcilers? - or at least the capability to support multiple reconcilers?

It'd be really cool to have:

  • ShallowReconciler, like React's ShallowRenderer - this is used for unit testing. It renders only a component's root return value and its immediate children, and no further.
  • TestReconciler, like React's TestRenderer - this is also used for unit testing. It completely renders a component tree to a series of objects.

@LPGhatguy LPGhatguy changed the title Refactor reconciler New reconciler May 16, 2018
@LPGhatguy
Copy link
Contributor Author

I updated the issue with a complete wishlist of the things I'm looking for in the new reconciler.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants