Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DarkTreeView rendering optimization. #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Quobi
Copy link

@Quobi Quobi commented Dec 29, 2020

Optimized the drawing of child nodes. It'll perform similar to listview, drawing only the visible elements within the viewport, thus making the scrolling smooth. With support for each child nodes.

Optimized the drawing of child nodes. It'll perform similar to listview, drawing only the visible elements within the viewport, thus making the scrolling smooth. With support for each child nodes.
@Quobi
Copy link
Author

Quobi commented Dec 29, 2020

Might want to change:

 bool isInTopView = Viewport.Top <= childNode.FullArea.Y;

To:

 bool isInTopView = Viewport.Top <= childNode.FullArea.Y + ItemHeight;

As the first visible node it's not drawn sometimes.

FallenAvatar added a commit to FallenAvatar/DarkUI that referenced this pull request Mar 19, 2021
DarkTreeView rendering optimization from Quobi:patch-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant