Fix code coverage (#42)

src/Helper/CacheableBicDictionaryTrait.php

@@ -34,7 +34,9 @@ private function cacheResult(IbanInterface $iban, string $bic): void
     private function getCached(IbanInterface $iban): string
     {
         if (!$this->isCached($iban)) {
+            // @codeCoverageIgnoreStart
             throw new CacheException("There is no cache for IBAN {$iban}");
+            // @codeCoverageIgnoreEnd
         }
 
         return $this->cache[$iban->asString()];

src/QrPayment.php

@@ -435,6 +435,16 @@ public function setPayeeAddressLine2(string $addressLine): QrPayment
         return $this;
     }
 
+    public function getPayeeAddressLine1(): string
+    {
+        return $this->payeeAddressLine1;
+    }
+
+    public function getPayeeAddressLine2(): string
+    {
+        return $this->payeeAddressLine2;
+    }
+
     public function getXzBinaryLocator(): XzBinaryLocatorInterface
     {
         return $this->xzBinaryLocator;

src/Xz/XzBinaryLocator.php

@@ -21,10 +21,14 @@ public function getXzBinary(): string
         if ($this->path === null) {
             exec('which xz', $output, $return);
             if ($return !== 0) {
+                // @codeCoverageIgnoreStart
                 throw new QrPaymentException("'xz' binary not found in PATH, specify it using setXzBinary()");
+                // @codeCoverageIgnoreEnd
             }
             if (!isset($output[0])) {
+                // @codeCoverageIgnoreStart
                 throw new QrPaymentException("'xz' binary not found in PATH, specify it using setXzBinary()");
+                // @codeCoverageIgnoreEnd
             }
             $this->path = $output[0];
         }

tests/Exception/InvalidTypeExceptionTest.php

@@ -0,0 +1,54 @@
+<?php
+
+namespace rikudou\SkQrPayment\Tests\Exception;
+
+use rikudou\SkQrPayment\Exception\InvalidTypeException;
+use PHPUnit\Framework\TestCase;
+use stdClass;
+
+class InvalidTypeExceptionTest extends TestCase
+{
+    public function testMessage()
+    {
+        self::assertEquals(
+            $this->getExpectedMessage('int', 'string'),
+            $this->getMessage('int', '')
+        );
+        self::assertEquals(
+            $this->getExpectedMessage("int' or 'string", 'array'),
+            $this->getMessage(['int', 'string'], [])
+        );
+        self::assertEquals(
+            $this->getExpectedMessage('string', 'integer'),
+            $this->getMessage('string', 5)
+        );
+        self::assertEquals(
+            $this->getExpectedMessage('5', 'double'),
+            $this->getMessage(5, 0.1)
+        );
+        self::assertEquals(
+            $this->getExpectedMessage('string', 'integer'),
+            $this->getMessage(new class {
+                public function __toString()
+                {
+                    return 'string';
+                }
+            }, 5)
+        );
+
+        self::assertEquals(
+            $this->getExpectedMessage('string', 'stdClass'),
+            $this->getMessage('string', new stdClass())
+        );
+    }
+
+    private function getExpectedMessage(string $expected, string $got): string
+    {
+        return "Expected '{$expected}', got '{$got}'";
+    }
+
+    private function getMessage($expected, $actual): string
+    {
+        return (new InvalidTypeException($expected, $actual))->getMessage();
+    }
+}

tests/QrPaymentTest.php

@@ -6,13 +6,16 @@
 use DateTimeInterface;
 use Endroid\QrCode\QrCode;
 use InvalidArgumentException;
+use Rikudou\BySquare\Decoder\PayBySquareDecoder;
+use Rikudou\BySquare\VO\DecodedBySquareData;
 use Rikudou\Iban\Iban\IBAN;
 use rikudou\SkQrPayment\Exception\InvalidTypeException;
 use rikudou\SkQrPayment\Exception\QrPaymentException;
 use rikudou\SkQrPayment\Payment\QrPaymentOptions;
 use rikudou\SkQrPayment\QrPayment;
 use PHPUnit\Framework\TestCase;
 use rikudou\SkQrPayment\Xz\XzBinaryLocator;
+use stdClass;
 use TypeError;
 
 class QrPaymentTest extends TestCase
@@ -92,7 +95,7 @@ public function testSetOptions()
         // test that values from array are type checked
         $this->expectException(TypeError::class);
         $this->instance->setOptions([
-            QrPaymentOptions::VARIABLE_SYMBOL => new \stdClass(),
+            QrPaymentOptions::VARIABLE_SYMBOL => new stdClass(),
         ]);
     }
 
@@ -226,7 +229,7 @@ public function __toString()
         self::assertSame('123', $this->instance->getVariableSymbol());
 
         $this->expectException(TypeError::class);
-        $this->instance->setVariableSymbol(new \stdClass());
+        $this->instance->setVariableSymbol(new stdClass());
     }
 
     public function testSetSpecificSymbol()
@@ -247,7 +250,7 @@ public function __toString()
         self::assertSame('123', $this->instance->getSpecificSymbol());
 
         $this->expectException(TypeError::class);
-        $this->instance->setSpecificSymbol(new \stdClass());
+        $this->instance->setSpecificSymbol(new stdClass());
     }
 
     public function testSetConstantSymbol()
@@ -268,6 +271,15 @@ public function __toString()
         self::assertSame('123', $this->instance->getConstantSymbol());
 
         $this->expectException(TypeError::class);
-        $this->instance->setConstantSymbol(new \stdClass());
+        $this->instance->setConstantSymbol(new stdClass());
+    }
+
+    public function testSetPayeeAddressLine()
+    {
+        $this->instance->setPayeeAddressLine1('123');
+        $this->instance->setPayeeAddressLine2('456');
+
+        self::assertEquals('123', $this->instance->getPayeeAddressLine1());
+        self::assertEquals('456', $this->instance->getPayeeAddressLine2());
     }
 }