Skip to content
This repository has been archived by the owner on Jan 11, 2019. It is now read-only.

Pass route params to handlers and demonstrate how they are used #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

csk157
Copy link

@csk157 csk157 commented Aug 19, 2015

It wasn't straightforward to setup routes with params, therefore I think it would be a good idea to always pass router parameters to as queryParams to the route handlers.

I also added a very basic example to demonstrate how it would work (with API).

Not sure, but it might be related to #54 and #56

@RickWong
Copy link
Owner

Hi @csk157 thanks for this Pull Request. It looks great, but instead of a random example, we would much rather do stargazers-pagination to demonstrate multiple routes + params. What do you think?

@csk157
Copy link
Author

csk157 commented Aug 20, 2015

Hi @RickWong, sounds good.
I would create a different route (component), which would mimic the behaviour of the Main route, just with manual pagination of the stargazers. So, both routes would essentially accomplish the same thing, but in slightly different ways. What do you think?

@csk157
Copy link
Author

csk157 commented Aug 20, 2015

Or maybe, you could click on the images in that Main list and open a route where it shows some information about the user (/stargazers/:githubUserName)?

@edimoldovan
Copy link

@csk157 I would love to see an example of both: manual pagination and stargazers detail route (/stargazers/:githubUserName).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants