Laravel 10 support #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm afraid I can't merge this, you've changed the license header, the name spaces, etc |
|
Whilst you can publish on packagist as it's MIT licensed, why have you rather than keep the singular package? However you have removed my Copyright from your license file which IS a breach of the MIT license |
|
Wasn’t sure you were still supporting this package or not. So I had to repackage to move forward with an app. If this is still going to be supported then I have no issues pushing prs here. On Jan 12, 2024, at 1:11 PM, Richard Hyland ***@***.***> wrote:
Whilst you can publish on packagist as it's MIT licensed, why have you rather than keep the singular package?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Indeed it is, we did have Christmas in the middle there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Illuminate/Support 10