Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the following changes:
playwright-test
for node tests instead ofvitest
deno
target for now. Deno should be able to load the node target, but we can revisit in the future if not.This PR brings in improvements we have been working on over in https://github.com/fission-codes/wasm-js.
We are testing node and a few frameworks over there, including SvelteKit, NextJS, and Preact.
Link to issue
No issue yet. Happy to open one if we want it.
Type of change
Test plan (required)
Run
npm run test
to test the included test. We may also want to test this withbetterboxd
to make sure it still works there.