Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update JS packaging #109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bgins
Copy link
Contributor

@bgins bgins commented Aug 25, 2023

Description

This PR implements the following changes:

  • Update package exports for broader support across JS frameworks and environments
  • Use playwright-test for node tests instead of vitest
  • Unify node and browser tests into a single test suite
  • Drop the deno target for now. Deno should be able to load the node target, but we can revisit in the future if not.

This PR brings in improvements we have been working on over in https://github.com/fission-codes/wasm-js.

We are testing node and a few frameworks over there, including SvelteKit, NextJS, and Preact.

Link to issue

No issue yet. Happy to open one if we want it.

Type of change

  • Refactor (non-breaking change that updates existing functionality)

Test plan (required)

Run npm run test to test the included test. We may also want to test this with betterboxd to make sure it still works there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant