Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor package item rn example #998

Closed

Conversation

onamfc
Copy link

@onamfc onamfc commented May 11, 2024

General cleanup of the React Native PackageItem component example.

  • remove undeclared style
  • update the reference to the deprecated property in the catch statement
  • replace purchaserInfo with customerInfo as the MakePurchaseResult type returns from the purchasePackage promise

Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @onamfc, the changes to MagicWeather look good! Would you be able to extract the changes to the yarn.lock out of this PR so we can get that merged?

As for the yarn.lock file changes, could you indicate exactly what changes happened and how did you update that file? It's going to be pretty difficult to review that file otherwise, and we might want to do that ourselves :)

remove yarn lock updates as they were only intended for local dev, not to be merged.
@onamfc
Copy link
Author

onamfc commented May 16, 2024

closing pull request in favor of submitting new branch with requested changes

@onamfc onamfc closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants