[WIP] Release 8.0 #919
Draft
[WIP] Release 8.0 #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkVillacampa
force-pushed
the
8.0-dev
branch
from
b5db8b8
to
b93b5eb
Compare
MarkVillacampa
commented
Feb 26, 2024
| @@ -1,7 +1,7 @@ | |||
| require_relative '../node_modules/react-native/scripts/react_native_pods' | |||
| require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules' | |||
|
|
|||
| platform :ios, min_ios_version_supported | |||
| platform :ios, "13.0" | |||
There was a problem hiding this comment.
Currently, min_ios_version_supported of React Native is 12.4 but we only support 13+ in the new iOS SDK
MarkVillacampa
force-pushed
the
8.0-dev
branch
from
bd99a62
to
82d728d
Compare
tonidero
reviewed
Feb 27, 2024
| public static async handleObserverModeTransaction(productID: string): Promise<PurchasesStoreTransaction> { | ||
| await Purchases.throwIfAndroidPlatform(); | ||
| await Purchases.throwIfNotConfigured(); | ||
| return RNPurchases.handleObserverModeTransactionForProductID(productID); |
There was a problem hiding this comment.
Hmm something I'm noticing is that this may return a null value in iOS <15... We either need to make the return type nullable or return an error (I don't think we can return a transaction).
I think returning an error might make more sense in this case?
There was a problem hiding this comment.
Switched to returning an error
| * | ||
| * You only need to use this method with *new* purchases. Subscription updates are observed automatically. | ||
| * | ||
| * Important: This should only be used if you have enabled observer mode during SDK configuration. |
There was a problem hiding this comment.
I think we don't do this in all methods... But we should document that this will fail if called on android or iOS <15
There was a problem hiding this comment.
Added clarification in the docs
tonidero
reviewed
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 8.0.0 of
react-native-purchasesbumps PHC to 10.0.0.NOTE: PHC 10.0 has not been released yet. These changes are pending updating the dependency version where appropriate.