Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ruby 3.2 on CircleCI #3896

Merged
merged 1 commit into from
May 15, 2024
Merged

Use Ruby 3.2 on CircleCI #3896

merged 1 commit into from
May 15, 2024

Conversation

joshdholtz
Copy link
Contributor

@joshdholtz joshdholtz commented May 15, 2024

This commit was already merged into 5.0-dev in #3894

Motivation

Releasing was failing with rb-readline and cocoapods in this job

CircleCI Xcode 15.3 defaults to Ruby 3.3 which was causing some issues

Description

Remove rb-readline hack and drop to Ruby 3.2 for CircleCI

### Motivation

Releasing was failing with `rb-readline` and `cocoapods` in [this
job](https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/19139/workflows/2b6ac90c-3f0f-438e-8964-365f47c2d31b/jobs/207470)

### Description

Remove `rb-readline` hack and drop to Ruby 3.2 for CircleCI
@joshdholtz joshdholtz added the ci Changes to our CI configuration files and scripts label May 15, 2024
@joshdholtz joshdholtz requested a review from a team May 15, 2024 02:46
@joshdholtz joshdholtz changed the title Use Ruby 3.2 on CircleCI (#3894) Use Ruby 3.2 on CircleCI May 15, 2024
@RevenueCat-Danger-Bot
Copy link

1 Message
📖 Size increase: 0.42 KB

Generated by 🚫 Danger

Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a question.

eval "$(rbenv init -)"
rbenv install -s 3.2.2 # Replace with your required Ruby version
rbenv global 3.2.2
rbenv rehash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was seeing the merged PR, did you try with switch-ruby from the macos orb? https://circleci.com/developer/orbs/orb/circleci/macos#commands-switch-ruby

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did! It didn't work for me 😬 I was tried switching to 3.2.2 with that and also printed the version after and it just didn't take which I thought was really weird 🤷‍♂️

I can try that again later today/tomorrow but I think this needs to get fixed before release train start otherwise cocoapods things will fail 😅

@joshdholtz joshdholtz merged commit 27012fd into main May 15, 2024
24 checks passed
vegaro pushed a commit that referenced this pull request Jun 3, 2024
**This is an automatic release.**

### New Features
* RemoteImage Low Res Image support (#3906) via James Borthwick
(@jamesrb1)
### Bugfixes
* [EXTERNAL] Hide decorative Paywall images from accessibility (#3886)
via @shiftingsand (#3892) via Toni Rico (@tonidero)
### Dependency Updates
* Bump rexml from 3.2.6 to 3.2.8 in
/Tests/InstallationTests/CocoapodsInstallation (#3908) via
dependabot[bot] (@dependabot[bot])
* Bump fastlane-plugin-revenuecat_internal from `dd5e21f` to `8ec0072`
(#3873) via dependabot[bot] (@dependabot[bot])
### Other Changes
* Revert to use xcode 14 to fix deploys (#3929) via Cesar de la Vega
(@vegaro)
* SPMInstallation tests deployment version increase (#3922) via Cesar de
la Vega (@vegaro)
* Only install `swiftlint` on Xcode 15 jobs (#3913) via Josh Holtz
(@joshdholtz)
* Add `http_request_performed` diagnostics event (#3897) via Toni Rico
(@tonidero)
* Paywalls Tester: App Store Prep (#3889) via James Borthwick
(@jamesrb1)
* Paywalls Tester: Enable Example Paywalls in Release Mode (#3885) via
James Borthwick (@jamesrb1)
* Use Ruby 3.2 on CircleCI (#3896) via Josh Holtz (@joshdholtz)
* PaywallsTester: Remove unused code (#3884) via James Borthwick
(@jamesrb1)
* Improved Error Handling (#3883) via James Borthwick (@jamesrb1)
* Clear diagnostics file if we detect it's too big during event tracking
(#3824) via Toni Rico (@tonidero)
* Preprocessor to make select constructs public (#3880) via James
Borthwick (@jamesrb1)
* Paywalls Tester: Use key defined in CI (#3869) via James Borthwick
(@jamesrb1)
* Cleanup: Remove test storekit configuration files when importing
through SPM (#3878) via Andy Boedo (@aboedo)
* Update fastlane plugin and fix docs index path (#3872) via Toni Rico
(@tonidero)
* Update to use xcode 15.3 in CI (#3870) via Cesar de la Vega (@vegaro)
* Paywalls Tester 0.1 (#3868) via James Borthwick (@jamesrb1)
* Update config.yml for SPM repo copy (#3861) via James Borthwick
(@jamesrb1)
* Change deploy-purchase-tester to use xcode 15 (#3858) via Cesar de la
Vega (@vegaro)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to our CI configuration files and scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants