Paywalls Tester: Enable Example Paywalls in Release Mode #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
jamesrb1
added a commit
that referenced
this pull request
May 14, 2024
This is temporarily needed to make it compile in release, but this will work again when #3885 is included
jamesrb1
added a commit
that referenced
this pull request
May 15, 2024
This is temporarily needed to make it compile in release, but this will work again when #3885 is included
jamesrb1
added a commit
that referenced
this pull request
May 15, 2024
This PR: - Updates the bundle name to com.revenuecat.app (a new app in App Store Connect has been set up.) - Updates the icon. - Update the app's Display Name to Revenue Cat. - Removes unneeded keys for "demos" and "testing". - Changes how keys are stored/managed locally. I'm not completely happy with this arrangement, but I think it's an improvement because local keys are now stored in a separate file which can be marked as `skip-worktree` or `assume-unchanged` which hides them from the diff to help you not commit changes in it accidentally (which I have done). - Adds a file in the pre-commit hook to check for keys in `LocalConfigItems.swift` For this to compile in release, and the demos tab to show up, the changes from [this PR](#3885) are needed.
This was referenced May 29, 2024
vegaro
pushed a commit
that referenced
this pull request
Jun 3, 2024
**This is an automatic release.** ### New Features * RemoteImage Low Res Image support (#3906) via James Borthwick (@jamesrb1) ### Bugfixes * [EXTERNAL] Hide decorative Paywall images from accessibility (#3886) via @shiftingsand (#3892) via Toni Rico (@tonidero) ### Dependency Updates * Bump rexml from 3.2.6 to 3.2.8 in /Tests/InstallationTests/CocoapodsInstallation (#3908) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `dd5e21f` to `8ec0072` (#3873) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Revert to use xcode 14 to fix deploys (#3929) via Cesar de la Vega (@vegaro) * SPMInstallation tests deployment version increase (#3922) via Cesar de la Vega (@vegaro) * Only install `swiftlint` on Xcode 15 jobs (#3913) via Josh Holtz (@joshdholtz) * Add `http_request_performed` diagnostics event (#3897) via Toni Rico (@tonidero) * Paywalls Tester: App Store Prep (#3889) via James Borthwick (@jamesrb1) * Paywalls Tester: Enable Example Paywalls in Release Mode (#3885) via James Borthwick (@jamesrb1) * Use Ruby 3.2 on CircleCI (#3896) via Josh Holtz (@joshdholtz) * PaywallsTester: Remove unused code (#3884) via James Borthwick (@jamesrb1) * Improved Error Handling (#3883) via James Borthwick (@jamesrb1) * Clear diagnostics file if we detect it's too big during event tracking (#3824) via Toni Rico (@tonidero) * Preprocessor to make select constructs public (#3880) via James Borthwick (@jamesrb1) * Paywalls Tester: Use key defined in CI (#3869) via James Borthwick (@jamesrb1) * Cleanup: Remove test storekit configuration files when importing through SPM (#3878) via Andy Boedo (@aboedo) * Update fastlane plugin and fix docs index path (#3872) via Toni Rico (@tonidero) * Update to use xcode 15.3 in CI (#3870) via Cesar de la Vega (@vegaro) * Paywalls Tester 0.1 (#3868) via James Borthwick (@jamesrb1) * Update config.yml for SPM repo copy (#3861) via James Borthwick (@jamesrb1) * Change deploy-purchase-tester to use xcode 15 (#3858) via Cesar de la Vega (@vegaro)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The paywalls examples weren't showing up when compiled in release mode. Enabling it meant making a bunch of more internal things public via the preprocessing script.
TestDatais no longer#ifdef DEBUGed out, but most of its data is still#ifdef DEBUG, and when it's compiled with aninternalmodifier and thus nothing uses it, I'd expect what remains to be stripped away during linking.