Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5.0.0 changes #3652

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

Release 5.0.0 changes #3652

wants to merge 56 commits into from

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Feb 7, 2024 •
edited

@NachoSoto NachoSoto added HOLD breaking Changes that are breaking labels Feb 7, 2024
@NachoSoto NachoSoto requested review from MarkVillacampa and a team February 7, 2024 19:12
This was referenced Feb 7, 2024
Closed
Closed
NachoSoto added a commit that referenced this pull request Feb 9, 2024
@NachoSoto
[move] Paywall: changed all Colors` to be optional
e1aeb09 
This will allow the implementation of color overrides by tier for the up-coming multi-tier paywall.

This is a backwards incompatible change, so we could include it in #3652.
NachoSoto added a commit that referenced this pull request Feb 9, 2024
@NachoSoto
[move] Paywall: changed all Colors` to be optional
90efd25 
This will allow the implementation of color overrides by tier for the up-coming multi-tier paywall.

This is a backwards incompatible change, so we could include it in #3652.
NachoSoto added a commit that referenced this pull request Feb 9, 2024
@NachoSoto
[move] Paywall: changed all Colors to be optional
2b4e92e 
This will allow the implementation of color overrides by tier for the up-coming multi-tier paywall.

This is a backwards incompatible change, so we could include it in #3652.
NachoSoto added a commit that referenced this pull request Feb 9, 2024
@NachoSoto
Paywall: changed all Colors to be optional
4c98f88 
This will allow the implementation of color overrides by tier for the up-coming multi-tier paywall.

This is a backwards incompatible change, so we could include it in #3652.
NachoSoto added a commit that referenced this pull request Feb 9, 2024
@NachoSoto
[move] Paywall: changed all Colors to be optional
44641db 
This will allow the implementation of color overrides by tier for the up-coming multi-tier paywall.

This is a backwards incompatible change, so we could include it in #3652.
NachoSoto added a commit that referenced this pull request Feb 9, 2024
@NachoSoto
[move] Paywall: changed all Colors to be optional
b894c54 
This will allow the implementation of color overrides by tier for the up-coming multi-tier paywall.

This is a backwards incompatible change, so we could include it in #3652.
NachoSoto added a commit that referenced this pull request Feb 9, 2024
@NachoSoto
[move] Paywall: changed all Colors to be optional
218cfd2 
This will allow the implementation of color overrides by tier for the up-coming multi-tier paywall.

This is a backwards incompatible change, so we could include it in #3652.
NachoSoto added a commit that referenced this pull request Feb 9, 2024
@NachoSoto
[move] Paywall: changed all Colors to be optional
249fbaf 
This will allow the implementation of color overrides by tier for the up-coming multi-tier paywall.

This is a backwards incompatible change, so we could include it in #3652.
NachoSoto added a commit that referenced this pull request Feb 12, 2024
@NachoSoto
Paywall: changed all Colors to be optional
a7a1fe2 
This will allow the implementation of color overrides by tier for the up-coming multi-tier paywall.

This is a backwards incompatible change, so we could include it in #3652.
NachoSoto added a commit that referenced this pull request Feb 12, 2024
@NachoSoto
Paywall: changed all Colors to be optional
521a084 
This will allow the implementation of color overrides by tier for the up-coming multi-tier paywall.

This is a backwards incompatible change, so we could include it in #3652.
NachoSoto added a commit that referenced this pull request Feb 12, 2024
@NachoSoto
[move] Paywall: changed all Colors to be optional
fac2ae0 
This will allow the implementation of color overrides by tier for the up-coming multi-tier paywall.

This is a backwards incompatible change, so we could include it in #3652.
@NachoSoto NachoSoto force-pushed the 5.0-dev branch 3 times, most recently from 878e414 to 14560db Compare February 14, 2024 19:10
@MarkVillacampa MarkVillacampa marked this pull request as ready for review April 9, 2024 16:45
@RevenueCat-Danger-Bot
Copy link

RevenueCat-Danger-Bot commented Apr 26, 2024 •
edited

1 Error
🚫 This PR increases the size of the repo by more than 250.00 KB (increased by 321.29 KB).
1 Message
📖 You can bypass the size check failure by adding the label "danger-bypass-size-limit". Please exercise caution.

Generated by 🚫 Danger

@MarkVillacampa @fire-at-will
[SK2] Add Configuration.with(storeKitVersion:) to select the versio…
fd0aaf4 
…n of StoreKit to use (#3487)

This PR introduces a new configuration option to select the StoreKit
version to use.

It supersedes the deprecated `.with(usesStoreKit2IfAvailable: true)` and
the internal `usesStoreKit2JWS` configuration options.

Uses JWS tokens instead of SK1 receipts when in StoreKit 2 mode where
applicable.

Example usage:
```swift
Purchases.configure(
            with: .builder(withAPIKey: apiKey)
                .with(storeKitVersion: .storeKit2)
                .build()
```
MarkVillacampa and others added 19 commits May 13, 2024 13:46
@MarkVillacampa @fire-at-will
[SK2]: Fix syncPurchases (#3700)
1754356 
We can use any transaction token available, not only auto-renewable ones
@MarkVillacampa @fire-at-will
Add v5 migration guide and update changelog (#3658)
338d5e7
@MarkVillacampa @fire-at-will
Commit all docs files (#3706)
1732803
@MarkVillacampa @fire-at-will
Do not update the documentation index.html file if version is prerele…
e602618 
…ase (#3711)

<!-- Thank you for contributing to Purchases! Before pressing the
"Create Pull Request" button, please provide the following: -->

### Checklist
- [ ] If applicable, unit tests
- [ ] If applicable, create follow-up issues for `purchases-android` and
hybrids

### Motivation
<!-- Why is this change required? What problem does it solve? -->
<!-- Please link to issues following this format: Resolves #999999 -->

### Description
<!-- Describe your changes in detail -->
<!-- Please describe in detail how you tested your changes -->
@MarkVillacampa @fire-at-will
Document SK2 is now the default
9619b11
@MarkVillacampa @fire-at-will
Fix tests
73649e9
@MarkVillacampa @fire-at-will
Fix snapshots
d6e3cfb
@MarkVillacampa @fire-at-will
fix gemfile
bd94d79
@MarkVillacampa @fire-at-will
remove ios 13 availability check
18a3248
@joshdholtz @fire-at-will
Change onChangeOf to be internal (#3788)
1d696b9 
### Motivation

`onChangeOf` was accidentally made public in #3517 

### Description

- Change scope of `onChangeOf` from `public` to `internal`
- Added breaking change in v5 migration doc
@fire-at-will
revert to using .storeKit1 where it was before rebase
c9a4f50
@fire-at-will
update diagnostics tests with SK2
79f9c6b
@tonidero @fire-at-will
Remove unneeded code after merging main
72d043b
@tonidero @fire-at-will
Update storekit version after merge
981009c
@fire-at-will
support SK2 in basic configure functions
6295e58
@fire-at-will
typo fix
74e2a33
@fire-at-will @jamesrb1
seamless SK2 observer mode
0c49f8a 
Co-authored-by: James Borthwick <109382862+jamesrb1@users.noreply.github.com>
@fire-at-will
CAT-1509: Update SDK to reflect new SK2 Observer Mode Changes
a897225
@fire-at-will
fix tests
915a9b8
fire-at-will and others added 10 commits May 13, 2024 15:02
@fire-at-will
linting
ea11c98
@fire-at-will
update gemfile
62cd421
@fire-at-will
tweaks for CI
ba4c035
@fire-at-will
dont let updating fastlane fail CI
513b8c2
@joshdholtz
Use Ruby 3.2 on CircleCI (#3894)
903d2a9 
### Motivation

Releasing was failing with `rb-readline` and `cocoapods` in [this
job](https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/19139/workflows/2b6ac90c-3f0f-438e-8964-365f47c2d31b/jobs/207470)

### Description

Remove `rb-readline` hack and drop to Ruby 3.2 for CircleCI
@fire-at-will
ios13 test pass
e5f2b58
@fire-at-will
macos observer mode doc updates
abfd07e
@joshdholtz
move switch-ruby to install-bundle-dependencies
911b898
@joshdholtz @fire-at-will @aboedo
Retry backend integration tests (#3902)
6c7a17e 
This is "ready for review" but it requires
#3833 to be merged into
it first to fully pass

### Motivation

Prevent the need to fully rerun all backend tests job when only a few
flaky tests fail

### Description

1. Runs backend integration tests
    - Parses junit.xml for failed tests
    - Writes them to a file
2. Runs new step in CircleCI
    - Looks at file for tests to re-run and only runs those tests
    - Merges new junit.xml into original junit.xml

The retry happens 4 times right now and will fail (raise an error) if
there are any left over tests that never ended up passing

---------

Co-authored-by: Will Taylor <wtaylor151@gmail.com>
Co-authored-by: Andy Boedo <andresboedo@gmail.com>
@fire-at-will
remove observer mode warning on SKVersion
e4566ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkVillacampa MarkVillacampa Awaiting requested review from MarkVillacampa

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking Changes that are breaking HOLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@NachoSoto @RevenueCat-Danger-Bot @MarkVillacampa @joshdholtz @fire-at-will @tonidero