Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude modules harmful to Vero4k and build for armv7 #2740

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

hissingshark
Copy link
Contributor

Changes:

  1. Build armv7 binaries from now on. This is harmless enough and may iron out a few quirks in Reicast. It definitely resolves the mystery dynarec bug in Mupen64plus triggered by the addition of 64 Disk Drive support . I have a PR out there to optionally disable 64 Disk Drive support in builds that are affected, but it hasn't had any attention. That is beyond our control, but this is not.
  2. There are only 2 modules in "main" that are totally toxic to the Vero4k. Excluding these means users can safely perform a the bulk "basic install" without breaking their systems Cannot build from source on vero4k due to mame4all #2738 .

Many thanks,

@joolswills
Copy link
Member

Thanks. Probably would be best to group these into different commits (but can still be done under one PR).

@joolswills joolswills merged commit 89cabe0 into RetroPie:master Jun 19, 2019
@hissingshark
Copy link
Contributor Author

Good point. I will do in future. Many thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants