New VAS (Visual Analogue Scale) answer format #708

ICONplcRK · 2016-06-09T04:57:21Z

The ORKVASScaleAnswerFormat class represents a visual analogue scale (VAS) answer format.

Using this, participants select a position on a continuous linear scale that represents how they rate their health condition by marking a point on a horizontal line between two endpoints. The health conditions represented by the endpoints of the line are described by the left and right anchor text: @param minimumValueDescription and @param maximumValueDescription respectively.
This scale is an electronic version of the standard 100cm visual analogue scale (VAS) used in many paper questionnaires and validated health instruments, particularly in the area of pain measurement. The VAS automatically scales to the optimal length for the device display, and the scientific literature contains strong validation evidence that the display length of the VAS does not influence the psychometric properties of the scale.
In common with the 100cm paper visual analogue scale, the scale answer format produces an ORKScaleQuestionResult object that returns an integer result from 0 to 100 with all possible integers between 0 to 100 measurable.
The style of marker used to indicate the point on the VAS that the participant has selected is controlled by @param markerStyle.
The presence or absence of arrows to associate the anchor text with the ends of the VAS line is controlled by @arrows.

YuanZhu-apple · 2016-06-10T21:03:23Z

ResearchKit.xcodeproj/project.pbxproj

@@ -3141,8 +3166,9 @@
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
 				MODULEMAP_FILE = ResearchKit/module.modulemap;
 				MTL_ENABLE_DEBUG_INFO = YES;
-				PRODUCT_BUNDLE_IDENTIFIER = "org.researchkit.${PRODUCT_NAME:rfc1034identifier}";
+				PRODUCT_BUNDLE_IDENTIFIER = nsg.resKit.VAS;


Revert this Product Bundle Identifier

YuanZhu-apple · 2016-06-10T21:09:24Z

@ICONplcRK Can you attach a screenshot for us to review?
Additionally, Can you put your testing code into ORKCatalog and ORKTest instead of ORKSample.
Normally we control what get shows up in ORKSample. Thanks!

ICONplcRK · 2016-06-10T21:35:42Z

Here are screenshots with answer with possible configurations:

YuanZhu-apple · 2016-06-10T22:40:29Z

Please correct me if I'm wrong.
Compared the existing continuous scale with VAS scale, I find a few difference.

VAS has a ticker at each ends
VAS don't show current value
VAS don't show a value label at each end
VAS has a different drag button.

Do you think it is possible to throw a few customization options to the existing continuous scale, and not introduce a new answer format?

ICONplcRK · 2016-06-10T22:47:22Z

In such case we need to add show/hide option to actual value, min and max labels, scale slider and change thumbnails, and to hide "scale markers" on slider. Additionally, is such cases user can change scale anyway (disabling this will be bad idea for all other slider formats). And is our case, this limit is essential, we collect in some way, patient "felling" about his/her situation, so original VAS has this fixed 0 to 100 scale.
For dis reason we decided to make it as a separate answer object.

YuanZhu-apple · 2016-06-10T23:25:04Z

@ICONplcRK

I still think you can make those options available for the existing continuous scale.
And create a convenient initializer for VAS.

VAS has a ticker at each ends
VAS don't show current value
VAS don't show a value label at each end
VAS has a different drag button.

ICONplcRK · 2016-06-10T23:33:13Z

Right now, existing continuous scales, don't have those min and max arrows, and have option only to show or hide tickers for scale, we want to emulate real measurement tool as close as possible, and in such case even using custom initializer we must expand a loot of existing classes and parametrize them.
IMHO creating classes to use specific tool, w/o fogging existing code is valid idea.

YuanZhu-apple · 2016-06-10T23:50:09Z

@ICONplcRK Can you please explain why the arrow between the scale and label are important?

IMHO ResearchKit is trying bring the research to the mobile, but not to copy everything. And that's not possible either. For example, user use finger instead of pen to do a survey.

The parametrization happens in the framework, so the developer won't notice it. To the developers, the custom initialer is easy to use.

And I am sure, even on paper not all the VAS looks the same, there could be some variants. That's why I think customization is good way to go.

lwrecza · 2016-10-06T19:39:21Z

@YuanZhu-apple Are you able to proceed with this ? We have updated the source code and our client ICON really needs this to be resolved. We need to have it closed until the conference session planned soon. Can you help us ? Much appreciated in advance.
Best,
Lukasz Wrecza

YuanZhu-apple · 2016-10-06T19:42:41Z

@lwrecza You have the freedom to keep the change in your fork. I don't see it is necessary to push it to the official repo.

lwrecza · 2016-10-06T19:49:46Z

@YuanZhu-apple There is a real value for other developers from having this part of code. Don't you think ? Why do you think it is not necessary to have it in the official repo or you suggest other way to merge this pull request ?

Best,
Lukasz Wrecza

YuanZhu-apple · 2016-10-06T20:04:16Z

@lwrecza I stated before.

@ICONplcRK Can you please explain why the arrow between the scale and label are important?

IMHO ResearchKit is trying bring the research to the mobile, but not to copy everything. And that's not possible either. For example, user use finger instead of pen to do a survey.

The parametrization happens in the framework, so the developer won't notice it. To the developers, the custom initialer is easy to use.

And I am sure, even on paper not all the VAS looks the same, there could be some variants. That's why I think customization is good way to go.

lwrecza · 2016-10-06T20:10:14Z

@YuanZhu-apple Thanks for coming back. We noted your comments and that's why we changed the code for customization and followed your advice. We submitted it today but still do not see any new commit. It should be 7th.

Best,
Lukasz

lwrecza · 2016-10-06T20:13:16Z

@YuanZhu-apple btw, we have yet 2 more pull requests in the pipe. Would be great to go forward with this one. On your rules here so count on your advice and support.
Best,
Lukasz

lwrecza · 2016-10-18T09:48:16Z

@YuanZhu-apple Hi. Is the fork closed ? We have submitted the changes but there are no updates under the commits section. Can you help ? Much appreciated in advance.
Best,
Lukasz

lwrecza · 2016-10-20T09:13:11Z

@YuanZhu-apple Friendly ping.
Best,
Lukasz

rsanchezsaez · 2016-10-20T16:42:16Z

@lwrecza: You have not submitted any new commits to this pull request since Yuan's comment regarding customizing the existing scale answer format instead of adding a new one.

Make sure you have pushed all the relevant commits to the master branch of your fork (which is the branch you created the PR from). Also, make sure you pull the latest official master into your mater and resolve any arising merge conflicts.

pharmpk · 2016-11-02T16:40:36Z

Is ORKVASScaleAnswerFormat available yet?

rsanchezsaez · 2016-11-02T16:44:44Z

@pharmpk Feedback needs to be addresses before this feature is considered for merging into the official ResearchKit repo. In the meantime, you're free to use the implementation in ICONplcRK's fork. ;-)

pharmpk · 2016-11-02T16:56:19Z

@rsanchezsaez Thanks for the reply. ResearchKit is an interesting challenge for an intermediate Swift programmer ;-) I was finally getting to the stage of developing a 'complete' application and heard about VAS yesterday. I'll have a look at ICONplcRK's fork. I'm still in the demoing possibilities stage so hopefully an official version will happen (soon enough). Thanks
... the ICONpicRK fork seems to be one Xcode/Swift version behind. Too many changes for me to resolve for now.

umerkhan-apple · 2017-01-24T19:20:39Z

@pharmpk Should we proceed with closing this PR for now?

pharmpk · 2017-01-24T20:19:50Z

@umerkhan-apple I'm not sure of GitHub protocol so I've probably asked in the wrong 'area'. I found mention of VAS here and wanted to incorporate it into a survey type application. A colleague indicated some interest if VAS was available but that has cooled. I'd like to dig a little deeper into ResearchKit in the future. As mentioned above the ICONpicRK fork seemed to have too many, for me, incompatibilities with the Xcode/Swift I was using for me to resolve. I probably should not have a 'vote' on closing the PR but I would like to see some progress with this task type or maybe more information about how to develop a new type of task. Thanks

umerkhan-apple · 2017-01-25T19:03:59Z

@pharmpk It would be nice to include this PR into RK. I will leave it open with a help wanted tag to see if anyone picks it up. Otherwise, we will have to close it. If you would like, you can create a separate PR with your implementation of VAS.

Janusz Bien added 5 commits March 17, 2016 14:41

VAS visual classes

a3b56fd

VAS Ansver integration

66a8c32

Fork update

820c090

VAS sample application version

1f20c49

Copyrights

5f057ea

YuanZhu-apple reviewed Jun 10, 2016
View reviewed changes

Bundle id, profile and sample update according to comments

238c168

umerkhan-apple mentioned this pull request Jan 24, 2017

Add a Image under or above a scale. #547

Open

umerkhan-apple added the help wanted label Jan 25, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New VAS (Visual Analogue Scale) answer format #708

New VAS (Visual Analogue Scale) answer format #708

ICONplcRK commented Jun 9, 2016

YuanZhu-apple Jun 10, 2016

YuanZhu-apple commented Jun 10, 2016 •

edited

ICONplcRK commented Jun 10, 2016

YuanZhu-apple commented Jun 10, 2016

ICONplcRK commented Jun 10, 2016

YuanZhu-apple commented Jun 10, 2016

ICONplcRK commented Jun 10, 2016

YuanZhu-apple commented Jun 10, 2016

lwrecza commented Oct 6, 2016

YuanZhu-apple commented Oct 6, 2016

lwrecza commented Oct 6, 2016

YuanZhu-apple commented Oct 6, 2016

lwrecza commented Oct 6, 2016 •

edited

lwrecza commented Oct 6, 2016

lwrecza commented Oct 18, 2016

lwrecza commented Oct 20, 2016

rsanchezsaez commented Oct 20, 2016 •

edited

pharmpk commented Nov 2, 2016

rsanchezsaez commented Nov 2, 2016 •

edited

pharmpk commented Nov 2, 2016 •

edited

umerkhan-apple commented Jan 24, 2017

pharmpk commented Jan 24, 2017

umerkhan-apple commented Jan 25, 2017

New VAS (Visual Analogue Scale) answer format #708

Are you sure you want to change the base?

New VAS (Visual Analogue Scale) answer format #708

Conversation

ICONplcRK commented Jun 9, 2016

YuanZhu-apple Jun 10, 2016

Choose a reason for hiding this comment

YuanZhu-apple commented Jun 10, 2016 • edited

ICONplcRK commented Jun 10, 2016

YuanZhu-apple commented Jun 10, 2016

ICONplcRK commented Jun 10, 2016

YuanZhu-apple commented Jun 10, 2016

ICONplcRK commented Jun 10, 2016

YuanZhu-apple commented Jun 10, 2016

lwrecza commented Oct 6, 2016

YuanZhu-apple commented Oct 6, 2016

lwrecza commented Oct 6, 2016

YuanZhu-apple commented Oct 6, 2016

lwrecza commented Oct 6, 2016 • edited

lwrecza commented Oct 6, 2016

lwrecza commented Oct 18, 2016

lwrecza commented Oct 20, 2016

rsanchezsaez commented Oct 20, 2016 • edited

pharmpk commented Nov 2, 2016

rsanchezsaez commented Nov 2, 2016 • edited

pharmpk commented Nov 2, 2016 • edited

umerkhan-apple commented Jan 24, 2017

pharmpk commented Jan 24, 2017

umerkhan-apple commented Jan 25, 2017

YuanZhu-apple commented Jun 10, 2016 •

edited

lwrecza commented Oct 6, 2016 •

edited

rsanchezsaez commented Oct 20, 2016 •

edited

rsanchezsaez commented Nov 2, 2016 •

edited

pharmpk commented Nov 2, 2016 •

edited