Fix TimeOfDayQuestionResult predicate comparison #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1391. Here, an alternative approach is presented for evaluating a TimeOfDayQuestionResult with the same inputs (
minimumExpectedHour,minimumExpectedMinutes,maximumExpectedHour,maximumExpectedMinutes) which only checks the minutes if the hour matches.To minimize the disruption to the
NSPredicatebuilder, this approach adds a check to see if the incomingsubPredicateFormatbegins with a parenthesis which would normally create an invalid predicate. If this is encountered, it passes more control to the caller to perform more complex comparisons with the expectation the caller will prefix keys with the required$z..A test is added to further demonstrate the bug and it's resolution.