Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range of Motion Tasks - added support for all device orientations #1358

Open
wants to merge 146 commits into
base: master
Choose a base branch
from

Conversation

davwillev
Copy link
Contributor

This pull request updates the Range of Motion tasks with support for all device orientations. Several enhancements have been made:

  • The task should now report correct angles irrespective of device orientation, whether portrait, portrait upside down, landscape left or landcape right (currently only portrait and landscape left are supported).
  • The ROM tasks now use physical device orientation (UIDeviceOrientation) instead of the orientation of the app's user interface (UIInterfaceOrientation). This is particularly important when the user is not lookimg at the screen (as in the ROM tasks).
  • An additional NSInteger 'orientation' result variable has been added to report the initial orientation of the device during the task. This will enable researchers and developers to see the orientation of the device at the commencement of the task.

davwillev and others added 30 commits December 9, 2018 09:53
Updating base to RK master
Update to latest RK version
…otation_start@3x.png"""""""

This reverts commit 1a5a34d.
…e neck_rotation_start@3x.png""""""""

This reverts commit 4949574.
This reverts commit 1228d34, reversing
changes made to 7b44835.
@davwillev
Copy link
Contributor Author

davwillev commented Mar 21, 2020

Apologies for the recent high number of commits. I realised that I had inadvertantly merged in some work that is 'in progress' and had to revert this. The PR is now clean and ready to merge

@davwillev
Copy link
Contributor Author

Hi @srinathtm-apple and @Pariecemckinney-apple
Is there any chance you could review these changes?
Thanks!

@davwillev
Copy link
Contributor Author

davwillev commented Jun 15, 2020

Hey @ninoguba
I spotted you are active at the moment. Any chance you could review these changes, since you are fairly familiar with the RoM tasks?
Much appreciated!

@ninoguba
Copy link
Contributor

@davwillev Hi. Actually I'm not very familiar with the RoM tasks so I'll defer first to folks at Apple to conduct their review of your PR. Please nudge them again.

@davwillev
Copy link
Contributor Author

OK, thanks, @ninoguba
@srinathtm-apple !?

@davwillev
Copy link
Contributor Author

@srinathtm-apple
I noticed that you were active here at the moment. ANy chance you could review this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants