Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video instruction step presentation improvements #1291

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

nicolelehrer
Copy link

  • Tries to address //FIXME: video instruction step needs to adopt ORKInstructionStepContainerView so that video playback works

    • updates are made to stepContentView instead of instructionImageView, which is unavailable on stepView
    • adds a yOffset calculation so that play button image is centered vertically with thumbnail height
  • Moves thumbnail calculation to background thread so video step presentation is not delayed

    • adds a placeholder image so that text doesn't bounce into place once thumbnail is created
    • once back on main thread, invokes stepDidChange again so presentation is updated
  • Other updates

    • sets clipsToBounds to true, which seemed to be required for the image not to overflow after rotating to landscape
    • adds a scale to fill default content mode for the video instruction step's video thumbnail, instead of stretching to fill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant