Video instruction step presentation improvements #1291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to address
//FIXME: video instruction step needs to adopt ORKInstructionStepContainerView
so that video playback worksstepContentView
instead ofinstructionImageView
, which is unavailable onstepView
yOffset
calculation so that play button image is centered vertically with thumbnail heightMoves thumbnail calculation to background thread so video step presentation is not delayed
stepDidChange
again so presentation is updatedOther updates
clipsToBounds
to true, which seemed to be required for the image not to overflow after rotating to landscape