Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeOfDayQuestionResult predicates fail if minutes > maximumExpectedMinutes regardless of hour #1391

Open
eschramm opened this issue Jul 21, 2020 · 0 comments · May be fixed by #1392
Open

TimeOfDayQuestionResult predicates fail if minutes > maximumExpectedMinutes regardless of hour #1391

eschramm opened this issue Jul 21, 2020 · 0 comments · May be fixed by #1392

Comments

@eschramm
Copy link
Contributor

The logic for comparison simply compares each component (minute and hour) independently against the minimum and maximum allowed for each. This doesn't take into account that the minutes should only be compared if the hour matches. For example, if the minimum is 6:00 AM and the maximum is 7:00 AM, a value of 6:06 AM should satisfy the predicate, however it currently fails because 6 is greater than the maximumExpectedMinutes of 0.
@eschramm eschramm linked a pull request Jul 21, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TimeOfDayQuestionResult predicate comparison CareEvolution/ResearchKit
1 participant
@eschramm