Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: yarn-deduplicate for string-width #1228

Merged
merged 4 commits into from Nov 6, 2023
Merged

Conversation

alexandre-abrioux
Copy link
Member

@alexandre-abrioux alexandre-abrioux commented Nov 2, 2023

Issue

Adding new dependencies in the packages/utils directory is impossible. If you navigate to cd packages/utils and try to install a new package, for instance yarn add eccrypto-js, you will face the issue:

error An unexpected error occurred: "expected workspace package to exist for \"string-width\"".

The issue is described here: yarnpkg/yarn#7807

Change

The solution was to run

npx yarn-deduplicate --packages string-width

I chose to only run the fix for this specific package and not all packages in the lock file as described in Yarn's GitHub comment (I tried it at first, but this led to more issues with the build).

@alexandre-abrioux alexandre-abrioux marked this pull request as ready for review November 2, 2023 22:20
@alexandre-abrioux alexandre-abrioux changed the title chore: run yarn-deduplicate chore: yarn-deduplicate for string-width Nov 2, 2023
@coveralls
Copy link

coveralls commented Nov 2, 2023

Coverage Status

coverage: 86.925%. remained the same
when pulling 0c9b726 on yarn-deduplicate
into a782146 on master.

@alexandre-abrioux alexandre-abrioux enabled auto-merge (squash) November 6, 2023 10:36
@alexandre-abrioux alexandre-abrioux merged commit f1d7ec4 into master Nov 6, 2023
25 checks passed
@alexandre-abrioux alexandre-abrioux deleted the yarn-deduplicate branch November 6, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants