Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alignment definitions to RTCHitNt and RTCRayNt #472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jan 19, 2024

  1. Added alignment definitions to RTCHitNt and RTCRayNt

    Added alignment definitions to RTCHitNt and RTCRayNt templates so they match the C definitions provided. As the alignment calculation is nasty without requiring the alignof keyword, or constexpr functions, this could instead be hidden behind a macro. Maybe RTC_ALIGN_SOA_AT_LEAST(N, MIN)?
    
    The code is equivalent to:
    ```
    constexpr std::size_t AlignSOAAtLeast(unsigned N, std::size_t min_alignment) noexcept {
        if (std::has_single_bit<unsigned>(N)) {
            return std::max<std::size_t>(min_alignment, N * alignof(float));
        } else {
            return min_alignment;
        }
    }
    ```
    Checking this works is as simple as adding a few static assertions:
    ```
    static_assert(alignof(embree::RTCRayNt<1>) == alignof(embree::RTCRay));
    static_assert(alignof(embree::RTCRayNt<4>) == alignof(embree::RTCRay4));
    static_assert(alignof(embree::RTCRayNt<8>) == alignof(embree::RTCRay8));
    static_assert(alignof(embree::RTCRayNt<16>) == alignof(embree::RTCRay16));
    ```
    dbs4261 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ee518e6 View commit details
    Browse the repository at this point in the history