Fix @rpath reference for macOS #455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The semantic equivalent of `$ORIGIN` on macOS is `@loader_path`. That seems to be the intent here, so let's use `@loader_path` instead of `@rpath`. Setting an RPATH of `@rpath` is, in any case, non-sensical. An `@rpath` reference tells dyld (the dynamic loader) to use the known RPATHs to resolve the reference, so adding `@rpath` to the list of known RPATHs doesn't give dyld any more information than it already has.
carlocab
added a commit
to carlocab/brew
that referenced
this pull request
Aug 5, 2023
This is just a recipe for infinite loops. Plus, recursive references are likely to be invalid, so we don't really gain much by attempting to resolve them.[^1] (But we could if we made the logic here much more complicated.) Fixes a CI failure seen at Homebrew/homebrew-core#138323. [^1]: See, for example, RenderKit/embree#455.
7 tasks
dduugg
pushed a commit
to dduugg/brew
that referenced
this pull request
Sep 30, 2023
This is just a recipe for infinite loops. Plus, recursive references are likely to be invalid, so we don't really gain much by attempting to resolve them.[^1] (But we could if we made the logic here much more complicated.) Fixes a CI failure seen at Homebrew/homebrew-core#138323. [^1]: See, for example, RenderKit/embree#455.
|
Thanks for the PR! This was merged into our internal devel branch and released with an earlier Embree release. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantic equivalent of
$ORIGINon macOS is@loader_path. That seems to be the intent here, so let's use@loader_pathinstead of@rpath.Setting an RPATH of
@rpathis, in any case, non-sensical. An@rpathreference tells dyld (the dynamic loader) to use the known RPATHs to resolve the reference, so adding@rpathto the list of known RPATHs doesn't give dyld any more information than it already has.