Remove searching for TBB in embree-config.cmake #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having `FIND_PACKAGE(TBB)` in `embree-config.cmake` adds an unnecessary constraint - namely that users now needs TBB development files on their system to use Embree. In environments with shared libraries like e.g. classic linux distributions, a user might have the shared libraries for TBB installed but not the developments files.
|
This breaks if the |
|
We have moved the find_package inside a IF(EMBREE_STATIC) conditional and replaced it with find_dependency. d411a39 Please let us know if the problem still persists. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
FIND_PACKAGE(TBB)inembree-config.cmakeadds an unnecessary constraint - namely that users now needs TBB development files on their system to use Embree. In environments with shared libraries like e.g. classic linux distributions, a user might have the TBB shared libraries for Embree installed but not the developments files. Any component checks should only happen during build time of Embree.Closes #401
/cc @sherholz-intel @svenwoop