Fix building OIIO tutorials with newer OIIO versions #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevented building the openimageio tutorials as newer openimageio versions supports only a minimum of c++14.
Newer OIIO version has split the library in two. The regular library and an utils library. The regular library depends on the utils library, so we need to include it as well if it is found.
DarkDefender
force-pushed
the
openimageio
branch
from
d0c9d69
to
89ec9a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer OIIO versions seems to require >CPP14 however embree currently forces c++11 causing the tutorials to fail with newer OIIO versions (tested with OIIO 2.3.17.0).
I don't know if changing the cpp version to be implicit is controversial or not.
But it at least works for me. ^^
In addition to this, the OIIO library finding needed to be updated as the main library now depends on the additional
_utilslibrary. Otherwise it would fail at the linking phase because of missing symbols.