Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing verify / Fixing EMBREE_RAY_PACKETS=OFF #275

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixing verify / Fixing EMBREE_RAY_PACKETS=OFF #275

wants to merge 4 commits into from

Commits on Mar 1, 2020

  1. Fix SSE2.update and further verify tests with EMBREE_RAY_PACKETS=OFF 

    To test this, run 'verify' with the arguments '--run .*SSE2.update.* --sequential'
    @maikschulze
    maikschulze committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    bf511b8 View commit details
    Browse the repository at this point in the history

  2. Fix immediate fail of 'SSE2.ray_masks' verify test.

    @maikschulze
    maikschulze committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    9420298 View commit details
    Browse the repository at this point in the history

  3. Fix SphereFilterMultiHitTest by setting inactive mask in order to not… 

    … filter out the computed hits in the epilog function.

Note that RTC_DEVICE_PROPERTY_BACKFACE_CULLING_ENABLED is not fully functional and appears to be always disabled in the intersector. Hence, the test will still fail when compiling with RTC_DEVICE_PROPERTY_BACKFACE_CULLING_ENABLED=OFF (reporting 4 instead of 2 hits)
    @maikschulze
    maikschulze committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    5a6ebd8 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. Fix the failure of the RayMasksTest which has accessed unwritten 'hit… 

    …' information on rtcOccluded. This information is only written on rtcIntersect. We blindly pass these cases.
    @maikschulze
    maikschulze committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    128ed96 View commit details
    Browse the repository at this point in the history