Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/HIT-274-add-new-type-of-permission-to-delete-application #41

Conversation

estelafs
Copy link

@estelafs estelafs commented Mar 25, 2024

Description

Created the permission can_delete_applications. Please remember to run npm run buid to created the permission in the db

Useful links

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Trying to deleting applications with and without the permission (and without the can_manage_applications permission)

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@estelafs estelafs added the enhancement New feature or request label Mar 25, 2024
@estelafs estelafs self-assigned this Mar 25, 2024
@estelafs estelafs changed the title created can_delete_applications permission feat/HIT-274-add-new-type-of-permission-to-delete-application Mar 25, 2024
@matheus-relief matheus-relief merged commit 28e4db0 into next-oort May 21, 2024
@matheus-relief matheus-relief deleted the feat/HIT-274-add-new-type-of-permission-to-delete-application branch May 21, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants