Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/HIT-204_automigrate-old-records #29

Open
wants to merge 1 commit into
base: hit-oort
Choose a base branch
from

Conversation

matheus-relief
Copy link
Collaborator

@matheus-relief matheus-relief commented Feb 8, 2024

Description

This PR adds a a new feature: Based on the form configuration, when altering the form structure, the old records already created from that form can try to update it's values automatically in case a question changes

Useful links

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

A lot of changes between radio/checkbox/text/resource/resources were made

Screenshots

(note that the record in the end had the correct value, but was appearing empty because of stale cache, out of scope)
https://github.com/ReliefApplications/oort-backend/assets/102038450/242ea4a7-7859-4726-86af-7662863ee459

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@matheus-relief
Copy link
Collaborator Author

@brunotannus please do as many tests as you can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants