Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change config validation order #1520

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

DmitryAnansky
Copy link
Contributor

@DmitryAnansky DmitryAnansky commented Apr 10, 2024

What/Why/How?

  • Changes to config validation flow, linting configuration with resolved config
  • Extended types mixed into other oas types

Changes in this PR also results in code changes for Project

Affected changes & tests => https://github.com/Redocly/redocly/pull/7855

Screenshot 2024-04-15 at 14 44 19

Reference

Closes #1223

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: 46903a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/openapi-core Minor
@redocly/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 982.8 ± 7.5 973.8 993.0 1.00 ± 0.02
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 978.4 ± 18.2 955.1 1011.1 1.00

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.84% 4420/5752
🟡 Branches 67.11% 2402/3579
🟡 Functions 70.61% 735/1041
🟡 Lines 77.01% 4150/5389
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / load.ts
87.93%
82.22% (+1.73% 🔼)
100%
88.89% (-1.11% 🔻)
🟢 core/src/lint.ts 95.65% 83.33% 100% 95.56%

Test suite run success

722 tests passing in 101 suites.

Report generated by 🧪jest coverage report action from 46903a5

@DmitryAnansky DmitryAnansky changed the title chore: wip config validation, extend types before feat: change config validation order Apr 10, 2024
@DmitryAnansky DmitryAnansky force-pushed the fix/config-validation-resolve-types branch from 2e40211 to 46903a5 Compare April 15, 2024 11:37
@DmitryAnansky DmitryAnansky marked this pull request as ready for review April 16, 2024 09:17
@DmitryAnansky DmitryAnansky requested review from a team as code owners April 16, 2024 09:17
"@redocly/cli": minor
---

Changed command execution flow to resolve configuration extendedTypes and plugins before linting it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Changed command execution flow to resolve configuration extendedTypes and plugins before linting it.
Changed resolution process to include extendedTypes and plugins before linting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeExtension isn't available to configurable rules
4 participants