Suggestion - add a full path hint for redistimeseries.so #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I run Redis Stack in a StatefulSet, and I had to exec into the container to `find . -name redistimeseries.so` so I could prepare my configmap with something like:
```
{{- if .Values.enableRedisTimeSeries }}
loadmodule /opt/redis-stack/lib/redistimeseries.so
{{- end }}
```
So I decided to suggest a brief comment on top of the configuration, just to help the next person.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1546 +/- ##
=======================================
Coverage 89.02% 89.02%
=======================================
Files 35 35
Lines 5834 5834
=======================================
Hits 5194 5194
Misses 640 640 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run Redis Stack in a StatefulSet, and I had to exec into the container to
find . -name redistimeseries.soso I could prepare my configmap with something like:So I decided to suggest a brief comment on top of the configuration, just to help the next person.