fix potential bug on ts.add and ts.madd, when there is specific type … #1503
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -279,4 +279,26 @@ def test_ts_upsert_bug(): | |||
| res2 = r.execute_command("ts.range", t1, first_chunk_last_ts, first_chunk_last_ts + 100) | |||
| info2 = TSInfo(r.execute_command("ts.info", t1, 'DEBUG')) | |||
| assert res2 == [res[0], [first_chunk_last_ts + 100, first_chunk_last_val]] | |||
|
|
|||
| def test_error(): | |||
There was a problem hiding this comment.
E302: expected 2 blank lines, found 1
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
…of errors the opened key isn't being closed
OfirMos
force-pushed
the
fix_bug_add_madd
branch
from
e672453
to
45da54f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1503 +/- ##
==========================================
+ Coverage 88.99% 89.03% +0.03%
==========================================
Files 35 35
Lines 5834 5844 +10
==========================================
+ Hits 5192 5203 +11
+ Misses 642 641 -1
☔ View full report in Codecov by Sentry. |
Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
…of errors the opened key isn't being closed
Currently there is no bug ,since RedisModule_AutoMemory is used and the key is anyway being closed, but in the future, this command would be ready to drop auto memory.