Fix Graphentity_Getattributes()

[nafraf]

This patch is to solve: #3050, #3054, and #3056.

The function AttributeSet GraphEntity_GetAttributes(GraphEntity *e) was modified to verify that the pointer e->attributes != NULL before trying to access its value.

[filipecosta90]

Automated performance analysis summary

This comment was automatically generated given there is performance data available.

In summary:

• Detected a total of 17 stable tests between versions.
• Detected a total of 1 highly unstable benchmarks.
• Detected a total of 1 improvements above the improvement water line.
• Detected a total of 1 regressions bellow the regression water line 5.0.

You can check a comparison in detail via the grafana link

Comparison between master and fix-graphentity-getattributes.

Time Period from 30 days ago. (environment used: oss-standalone)

Test Case	Baseline master (median obs. +- std.dev)	Comparison fix-graphentity-getattributes (median obs. +- std.dev)	% change (higher-better)	Note
ENTITY_COUNT	33324 +- 0.0% (7 datapoints)	33324 +- nan% (1 datapoints)	-0.0%	-- no change --
EXPLICIT-EDGE-DELETION	100 +- 0.0% (7 datapoints)	100 +- nan% (1 datapoints)	-0.0%	-- no change --
GRAPH500-SCALE_18-EF_16-1_HOP	33325 +- 24.4% UNSTABLE (7 datapoints)	33325 +- nan% (1 datapoints)	-0.0%	UNSTABLE (very high variance)
GRAPH500-SCALE_18-EF_16-1_HOP_MIXED_READ_65perc_WRITE_25perc_DEL_10perc	50 +- 0.0% (7 datapoints)	50 +- nan% (1 datapoints)	-0.0%	-- no change --
GRAPH500-SCALE_18-EF_16-1_HOP_MIXED_READ_75perc_WRITE_25perc	56 +- 2.2% (7 datapoints)	59 +- nan% (1 datapoints)	5.9%	IMPROVEMENT
GRAPH500-SCALE_18-EF_16-2_HOP	9999 +- 4.4% (7 datapoints)	9999 +- nan% (1 datapoints)	0.0%	-- no change --
GRAPH500-SCALE_18-EF_16-2_HOP_MIXED_READ_75perc_WRITE_25perc	56 +- 2.9% (7 datapoints)	56 +- nan% (1 datapoints)	-0.0%	-- no change --
GRAPH500-SCALE_18-EF_16-3_HOP	901 +- 1.9% (7 datapoints)	901 +- nan% (1 datapoints)	0.0%	-- no change --
GRAPH500-SCALE_18-EF_16-3_HOP_MIXED_READ_75perc_WRITE_25perc	56 +- 2.0% (7 datapoints)	56 +- nan% (1 datapoints)	0.0%	-- no change --
IMPLICIT-EDGE-DELETION	17 +- 0.0% (7 datapoints)	17 +- nan% (1 datapoints)	0.0%	-- no change --
INSPECT-EDGES	2500 +- 0.0% (7 datapoints)	2500 +- nan% (1 datapoints)	0.0%	-- no change --
MIX_READ_WRITE	10000 +- 0.0% (7 datapoints)	10000 +- nan% (1 datapoints)	0.0%	-- no change --
NODE-BATCH-DELETE	50 +- 0.0% (7 datapoints)	50 +- nan% (1 datapoints)	-0.0%	-- no change --
NODE-INDEX-LOOKUP	33 +- 0.0% (7 datapoints)	33 +- nan% (1 datapoints)	-0.0%	-- no change --
SORT_ENTITIES	100 +- 0.0% (7 datapoints)	100 +- nan% (1 datapoints)	-0.0%	-- no change --
UPDATE-BASELINE	24999 +- 0.0% (7 datapoints)	24999 +- nan% (1 datapoints)	-0.0%	-- no change --
VARIABLE-LENGTH-FILTER	33325 +- 0.0% (7 datapoints)	33325 +- nan% (1 datapoints)	-0.0%	-- no change --
VARIABLE_LENGTH_EXPAND_INTO	100 +- 0.0% (7 datapoints)	100 +- nan% (1 datapoints)	0.0%	-- no change --
allShortestPaths-10hop-100Kpaths	30 +- 4.4% (7 datapoints)	27 +- nan% (1 datapoints)	-9.1%	REGRESSION
allShortestPaths-4hop-10Kpaths	333 +- 3.1% (7 datapoints)	333 +- nan% (1 datapoints)	0.0%	-- no change --

[codecov]

Codecov Report

Patch coverage: 98.67% and project coverage change: +0.07 🎉

Comparison is base (86d6c12) 90.85% compared to head (b904f05) 90.93%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3080      +/-   ##
==========================================
+ Coverage   90.85%   90.93%   +0.07%     
==========================================
  Files         294      294              
  Lines       30269    30454     +185     
==========================================
+ Hits        27502    27694     +192     
+ Misses       2767     2760       -7     

Impacted Files	Coverage Δ
src/arithmetic/string_funcs/string_funcs.c	97.26% <ø> (ø)
src/execution_plan/ops/op_node_by_id_seek.c	80.82% <81.25%> (+0.54%)	⬆️
src/ast/ast_validations.c	97.85% <99.64%> (+0.74%)	⬆️
src/execution_plan/ops/op_merge_create.c	97.94% <100.00%> (ø)
src/execution_plan/ops/shared/update_functions.c	98.25% <100.00%> (ø)
src/graph/entities/graph_entity.c	30.55% <100.00%> (-1.27%)	⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.