Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation of remove property #3046

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

nafraf
Copy link
Contributor

@nafraf nafraf commented Apr 22, 2023

This patch is to fix #3043

The validations of remove property were modified to support expressions of type CYPHER_AST_IDENTIFIER and CYPHER_AST_NULL

@nafraf nafraf marked this pull request as ready for review April 22, 2023 19:04
@filipecosta90
Copy link
Collaborator

filipecosta90 commented May 13, 2023

Automated performance analysis summary

This comment was automatically generated given there is performance data available.

In summary:

  • Detected a total of 16 stable tests between versions.
  • Detected a total of 1 highly unstable benchmarks.
  • Detected a total of 1 improvements above the improvement water line.
  • Detected a total of 2 regressions bellow the regression water line 5.0.

You can check a comparison in detail via the grafana link

Comparison between master and fix-remove-property-from-null.

Time Period from 30 days ago. (environment used: oss-standalone)

Test Case Baseline master (median obs. +- std.dev) Comparison fix-remove-property-from-null (median obs. +- std.dev) % change (higher-better) Note
ENTITY_COUNT 33324 +- 0.0% (7 datapoints) 33323 +- nan% (1 datapoints) -0.0% -- no change --
EXPLICIT-EDGE-DELETION 100 +- 0.0% (7 datapoints) 100 +- nan% (1 datapoints) -0.0% -- no change --
GRAPH500-SCALE_18-EF_16-1_HOP 33325 +- 24.4% UNSTABLE (7 datapoints) 33325 +- nan% (1 datapoints) 0.0% UNSTABLE (very high variance)
GRAPH500-SCALE_18-EF_16-1_HOP_MIXED_READ_65perc_WRITE_25perc_DEL_10perc 50 +- 0.0% (7 datapoints) 50 +- nan% (1 datapoints) -0.0% -- no change --
GRAPH500-SCALE_18-EF_16-1_HOP_MIXED_READ_75perc_WRITE_25perc 56 +- 2.2% (7 datapoints) 59 +- nan% (1 datapoints) 5.9% IMPROVEMENT
GRAPH500-SCALE_18-EF_16-2_HOP 9999 +- 4.4% (7 datapoints) 9999 +- nan% (1 datapoints) 0.0% -- no change --
GRAPH500-SCALE_18-EF_16-2_HOP_MIXED_READ_75perc_WRITE_25perc 56 +- 2.9% (7 datapoints) 56 +- nan% (1 datapoints) -0.0% -- no change --
GRAPH500-SCALE_18-EF_16-3_HOP 901 +- 1.9% (7 datapoints) 901 +- nan% (1 datapoints) 0.0% -- no change --
GRAPH500-SCALE_18-EF_16-3_HOP_MIXED_READ_75perc_WRITE_25perc 56 +- 2.0% (7 datapoints) 56 +- nan% (1 datapoints) -0.0% -- no change --
IMPLICIT-EDGE-DELETION 17 +- 0.0% (7 datapoints) 17 +- nan% (1 datapoints) 0.0% -- no change --
INSPECT-EDGES 2500 +- 0.0% (7 datapoints) 2500 +- nan% (1 datapoints) -0.0% -- no change --
MIX_READ_WRITE 10000 +- 0.0% (7 datapoints) 10000 +- nan% (1 datapoints) -0.0% -- no change --
NODE-BATCH-DELETE 50 +- 0.0% (7 datapoints) 50 +- nan% (1 datapoints) 0.0% -- no change --
NODE-INDEX-LOOKUP 33 +- 0.0% (7 datapoints) 33 +- nan% (1 datapoints) -0.0% -- no change --
SORT_ENTITIES 100 +- 0.0% (7 datapoints) 100 +- nan% (1 datapoints) 0.0% -- no change --
UPDATE-BASELINE 24999 +- 0.0% (7 datapoints) 25000 +- nan% (1 datapoints) 0.0% -- no change --
VARIABLE-LENGTH-FILTER 33325 +- 0.0% (7 datapoints) 33326 +- nan% (1 datapoints) 0.0% -- no change --
VARIABLE_LENGTH_EXPAND_INTO 100 +- 0.0% (7 datapoints) 100 +- nan% (1 datapoints) 0.0% -- no change --
allShortestPaths-10hop-100Kpaths 30 +- 4.4% (7 datapoints) 27 +- nan% (1 datapoints) -9.1% REGRESSION
allShortestPaths-4hop-10Kpaths 333 +- 3.1% (7 datapoints) 312 +- nan% (1 datapoints) -6.3% REGRESSION

@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (fd65140) 90.46% compared to head (0fe7180) 90.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3046      +/-   ##
==========================================
+ Coverage   90.46%   90.47%   +0.01%     
==========================================
  Files         288      288              
  Lines       28750    28757       +7     
==========================================
+ Hits        26008    26019      +11     
+ Misses       2742     2738       -4     
Impacted Files Coverage Δ
src/ast/ast_build_op_contexts.c 97.14% <100.00%> (+0.04%) ⬆️
src/ast/ast_build_reference_map.c 99.17% <100.00%> (+<0.01%) ⬆️
src/execution_plan/ops/op_update.c 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash due to untrue assertion astnode_type==CYPHER_AST_IDENTIFIER
2 participants