Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2983

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update README.md #2983

wants to merge 2 commits into from

Conversation

LiorKogan
Copy link
Member

@LiorKogan LiorKogan commented Mar 23, 2023

Fix build instructions.
README structure and build instructions are now similar to RTS and RB.

Fix build instruction.
Structure and build instructions are now similar to RTS and RB.
Comment on lines +44 to 57
First step is to have Redis installed, of course. The following, for example, builds Redis on a clean Ubuntu docker image (`docker pull ubuntu`):

```
mkdir ~/Redis
cd ~/Redis
apt-get update -y && apt-get upgrade -y
apt-get install -y wget make pkg-config build-essential
wget https://download.redis.io/redis-stable.tar.gz
tar -xzvf redis-stable.tar.gz
cd redis-stable
make distclean
make
make install
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. To build RedisGraph we don't need Redis.
  2. apt-get isn't available on all Linux distros

I wouldn't mention this step.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course people who already have Redis can skip this part, but the assumption here is that many people don't have Redis yet, and we want to instruct them how to start from nothing and reach the point were they have RedisGraph running.

Re apt-get - true, but as I stated - this is an example were you start with a clean Ubuntu docker image.

And again - we have similar build instructions for RTS and RB now. There were many issues like #2982 across all modules - and I believe it is now solved for RTS and RB (anyway - I'll keep syncing all 3 repos on new issues).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have few notes about this. Sent a DM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants