New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #2983
base: master
Are you sure you want to change the base?
Update README.md #2983
Conversation
Fix build instruction. Structure and build instructions are now similar to RTS and RB.
First step is to have Redis installed, of course. The following, for example, builds Redis on a clean Ubuntu docker image (`docker pull ubuntu`): | ||
|
||
``` | ||
mkdir ~/Redis | ||
cd ~/Redis | ||
apt-get update -y && apt-get upgrade -y | ||
apt-get install -y wget make pkg-config build-essential | ||
wget https://download.redis.io/redis-stable.tar.gz | ||
tar -xzvf redis-stable.tar.gz | ||
cd redis-stable | ||
make distclean | ||
make | ||
make install | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- To build RedisGraph we don't need Redis.
apt-get
isn't available on all Linux distros
I wouldn't mention this step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course people who already have Redis can skip this part, but the assumption here is that many people don't have Redis yet, and we want to instruct them how to start from nothing and reach the point were they have RedisGraph running.
Re apt-get
- true, but as I stated - this is an example were you start with a clean Ubuntu docker image.
And again - we have similar build instructions for RTS and RB now. There were many issues like #2982 across all modules - and I believe it is now solved for RTS and RB (anyway - I'll keep syncing all 3 repos on new issues).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also have few notes about this. Sent a DM.
Fix build instructions.
README structure and build instructions are now similar to RTS and RB.